commit 1723fe4a5244cd52edcff60ba79530475d4bfade
author Ben Zhang <benzh@chromium.org> Tue Aug 23 16:32:51 2016 -0700
committer Bernie Thompson <bhthompson@chromium.org> Wed Aug 24 00:15:38 2016 +0000
tree 7921323e799a19602e070cdcb3d775968e824985
parent c4d85b2f512ce53756e484909e289d1772713f4d

gsutil_util: Add detailed logging for crbug.com/639314

This is for debugging the canary AUTest failures.
Logs return code, stdout, stderr from gsutil, and
the pattern matching logic in GetGSNamesWithWait.

This must be reverted when the issue is resolved.

BUG=chromium:639314
TEST=Manually run full_release_test.py

Change-Id: Id07dfc7a1251eab69a683eb9649cbf2811e7db7b
Signed-off-by: Ben Zhang <benzh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374473
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

gsutil_util.py

diff --git a/gsutil_util.py b/gsutil_util.py
index dfbd1a7..c3fdb9a 100644
--- a/gsutil_util.py
+++ b/gsutil_util.py
@@ -55,6 +55,8 @@
     proc = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE,
                             stderr=subprocess.PIPE)
     stdout, stderr = proc.communicate()
+    _Log('crbug.com/639314 GSUtilRun({0}, {1})={2}, stdout=<<<{3}>>>, stderr=<<<{4}>>>'.format(
+        cmd, err_msg, proc.returncode, stdout, stderr))
     if proc.returncode == 0:
       return stdout
 
@@ -145,19 +147,23 @@
                       None))
 
   deadline = time.time() + timeout
+  _Log('crbug.com/639314 GetGSNamesWithWait():')
   while True:
     uploaded_list = []
     for cmd, msg, override_result in get_methods:
       try:
         result = GSUtilRun(cmd, msg)
       except GSUtilError:
+        _Log('crbug.com/639314 GSUtilError, try next method')
         continue  # It didn't work, try the next method.
 
       if override_result:
+        _Log('crbug.com/639314 override_result={0}'.format(override_result))
         result = override_result
 
       # Make sure we're dealing with artifact base names only.
       uploaded_list = [os.path.basename(p) for p in result.splitlines()]
+      _Log('crbug.com/639314 uploaded_list={0}'.format(uploaded_list))
       break
 
     # Only keep files matching the target artifact name/pattern.
@@ -168,6 +174,8 @@
     else:
       matching_names = fnmatch.filter(uploaded_list, pattern)
 
+    _Log('crbug.com/639314 matching_names={0}, is_regex_pattern={1}'.format(
+        matching_names, is_regex_pattern))
     if matching_names:
       return matching_names