commit 0b0ebdd83d9cb764bf6d43539ea3f56bc4223510
author Dominik Behr <dbehr@chromium.org> Tue Oct 01 15:01:43 2013 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Thu Oct 03 03:47:40 2013 +0000
tree 92de9bad7644145bc915a1c11ed5aefef2db624e
parent 69878b44aed8ee8cfd8c1b432cc8b6f036da3ca8

gdb_remote: add remote exec arguments and --ssh support for VM

Added new option to specify command line arguments for remote executable
to be debugged. Also added VM_PORT when invoking gdb server in ssh mode
so --ssh option would work with VM.

TEST=gdb_remote --remote=localhost --ssh --remote_file=/bin/ls \
 --remote_args=-al

Change-Id: Id0d83247664e4a3f87da1af014cf171f209e2704
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/171446

host/gdb_remote

diff --git a/host/gdb_remote b/host/gdb_remote
index 447c351..f966617 100755
--- a/host/gdb_remote
+++ b/host/gdb_remote
@@ -19,6 +19,8 @@
  "Process ID of the running process on the remote device to which to attach."
 DEFINE_string remote_file "" \
  "Full pathname of the file to be debugged on the remote device."
+DEFINE_string remote_args "" \
+ "Command line arguments to pass to the executable on the remote device."
 DEFINE_boolean cgdb ${FLAGS_FALSE} \
  "Use cgdb curses interface rather than plain gdb."
 DEFINE_boolean ssh ${FLAGS_FALSE} \
@@ -193,7 +195,7 @@
 {
   # Start gdbserver on the remote device
 
-  local gdbserver_cmd="gdbserver :${FLAGS_port} ${FLAGS_remote_file}"
+  local gdbserver_cmd="gdbserver :${FLAGS_port} ${FLAGS_remote_file} ${FLAGS_remote_args}"
   if [[ ${FLAGS_remote_pid} -ne 0 ]] ; then
     gdbserver_cmd="gdbserver --attach :${FLAGS_port} ${FLAGS_remote_pid}"
   fi
@@ -214,11 +216,11 @@
     if [[ ${FLAGS_remote_pid} -ne 0 ]] ; then
       gdbserver_cmd+=" --attach -  ${FLAGS_remote_pid}"
     else
-      gdbserver_cmd+=" - ${FLAGS_remote_file}"
+      gdbserver_cmd+=" - ${FLAGS_remote_file} ${FLAGS_remote_args}"
     fi
     remote_cmd="\"target remote | ssh -T -i ${TMP_DIR}/testing_rsa \
       ${REMOTE_SSH_FLAGS} -o TCPKeepAlive=no -o UserKnownHostsFile=/dev/null \
-      root@${FLAGS_remote} ${gdbserver_cmd}\""
+      root@${FLAGS_remote} ${VM_PORT} ${gdbserver_cmd}\""
   fi
 
   cat <<-EOF > ${GDBINIT_FILE}