)]}' { "commit": "4e155ea3a84069d3612bf8c2d8c762c94c369eb2", "tree": "3f0d5845724fa45e57fdb3f335f634666e0f6361", "parents": [ "8b137454be2c0ced56833e2404c655fc2b0f55a6" ], "author": { "name": "Chris Sosa", "email": "sosa@chromium.org", "time": "Thu Dec 19 16:29:37 2013 -0800" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Fri Dec 20 18:44:30 2013 +0000" }, "message": "Re-land: Use the layout.json file to actually build the FS\u0027s specified in it.\n\nThis CL refactors a bit how we build the initial base image and how we\ncreate FS\u0027s for the partitions. Specifically, I\u0027m changing base image\ncreation to work just like dev and test image creation. In the latter two,\nwe use mount_gpt_image.sh to mount the existing image.bin file already\ncontaing the gpt layout and fs\u0027s and just emerge into the directories. I\ndo this for the base image as well by creating the GPT image and fs\u0027s first.\nIn order to facilitate that, I moved the mk_fs work to disk_layout_util.sh\nwhich has a new build method build_gpt_image that does what indicated. In\naddition to that refactoring I had to better centralize all the mount point\nlogic which I\u0027ve moved into mk_fs (creates the stateful and rootfs mount\nmounts). Finally, I\u0027ve modified mount_gpt_image to always mount the oem\npartition to both persist and extend how the oem partition gets layed on\nthe rootfs.\n\nIn addition to fixing the below bug, this CL should make building any image\nfaster since we avoid half the IO (we don\u0027t have to dd a bunch of data when\nwe create the base image).\n\nFinally, this CL was reverted previously because we were creating partition\n5 (ROOT-B) now which is actually a waste of time (and breaks when we have\nsmall ROOT-B\u0027s in some layouts that don\u0027t specify a smaller fs_blocks). So,\nin this patch I removed all fs_format/fs_bytes for partitions we don\u0027t want\nthe build system to actually create.\n\nBUG\u003dchromium:325495\nTEST\u003dStill going but built various images to completion. Everything is mounted\ncorrectly. Going to create some deltas before and after.\n\nChange-Id: I5f45509e87341386973823890f6f69d1ee069e0b\nReviewed-on: https://chromium-review.googlesource.com/180964\nTested-by: Chris Sosa \u003csosa@chromium.org\u003e\nReviewed-by: Chris Sosa \u003csosa@chromium.org\u003e\nCommit-Queue: Chris Sosa \u003csosa@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "8b90575fdba3f1d4c1567ef68d14c3452bf882b4", "old_mode": 33261, "old_path": "build_library/base_image_util.sh", "new_id": "36027fc7e5bce87bc0eca0a081eb8e6968866454", "new_mode": 33261, "new_path": "build_library/base_image_util.sh" }, { "type": "modify", "old_id": "7d9d1452e2e2adc8d19ef03c4b45a354c6d98485", "old_mode": 33261, "old_path": "build_library/cgpt.py", "new_id": "2305ec2bdecf05963faa19192500663aee1d3202", "new_mode": 33261, "new_path": "build_library/cgpt.py" }, { "type": "modify", "old_id": "fa2e081774bfd31ba2e13e68b1f2ebb7962d5425", "old_mode": 33188, "old_path": "build_library/disk_layout_util.sh", "new_id": "4bc616bd673ab43b058a59821d51c657d5eae20d", "new_mode": 33188, "new_path": "build_library/disk_layout_util.sh" }, { "type": "modify", "old_id": "53db1b3ff03e602bae11ca9e251917ad8524141d", "old_mode": 33188, "old_path": "build_library/legacy_disk_layout.json", "new_id": "8aea95ca512f7919bde5500e281efe7b74635f86", "new_mode": 33188, "new_path": "build_library/legacy_disk_layout.json" }, { "type": "modify", "old_id": "981685484bbb9a2eca7c8c26e03877f40fe1252d", "old_mode": 33188, "old_path": "common.sh", "new_id": "9577aabfde3bef29661267c9135ebff0823ca62d", "new_mode": 33188, "new_path": "common.sh" }, { "type": "modify", "old_id": "9d813c7245d3e2aaa00966511bf617d4df39243e", "old_mode": 33261, "old_path": "mount_gpt_image.sh", "new_id": "aac9e62a8c853d8217a98421c3bc534d9439bf84", "new_mode": 33261, "new_path": "mount_gpt_image.sh" } ] }