| commit | 042783a60dda7ebba94a702e7baafdc06775f4e2 | [log] [tgz] |
|---|---|---|
| author | Allen Li <ayatane@google.com> | Mon Nov 06 14:38:38 2017 -0800 |
| committer | chrome-bot <chrome-bot@chromium.org> | Tue Nov 07 15:25:19 2017 -0800 |
| tree | 041e861855a4c24700e4c0a4f02114eb12154671 | |
| parent | 0522483084841757f1e1b8e422fdcd777ba471c6 [diff] |
Add new subprocess32 BUG=None TEST=None Change-Id: Ifbfd50dfd1829fcb21cc8032b19d07b65df54e4a Reviewed-on: https://chromium-review.googlesource.com/755941 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com>
This repository provides a common Python virtualenv interface that Chromium OS infrastructure code can depend on.
A repository adding virtualenv should mimic this repository, which itself uses virtualenv for running unit tests.
Key files:
bin/python_venv starts an instance of Python that uses the virtualenv.bin/turtle is an example script for running a Python module using bin/python_venvvenv/requirements.txt lists the packages to install inside the virtualenv. Refer to Pip's documentation for the requirements.txt format.venv is added to PYTHONPATH. For example, venv/cros_venv can be imported inside the virtualenv using import cros_venv.Packages to be installed inside a virtualenv must first be added to pip_packages.
To add packages, run:
$ bin/python_venv -m pip wheel -w pip_packages <packages to install>
Refer to Pip's documentation for details on the arguments for pip.
Commit the added package and make a CL.
Add the packages to requirements.txt. If the packages are not in pip_packages yet, add the packages to pip_packages.
“First party modules” refers to Chromium OS code (anything checked out by repo).
NOTE: Do not use this for third party dependencies (stuff not owned by Chromium OS)! This should only be used to set up imports for stuff we own. For example, importing python-MySQL SHOULD NOT use this, but importing chromite MAY use this.
There are two ways to do this:
venv.sys.path in __init__.py.Adding a symlink to venv is simple and should be self-explanatory. However, keep in mind that repo checkouts may not always have the same structure, and certain environments such as production servers may check out repositories in completely different locations. This method is not powerful enough to account for these environments.
Modifying sys.path is a lot more powerful. The way to do this is to add a small bit of code to the __init__.py of the package that needs the import.
Example (do not copy and paste blindly):
import os
import sys
# The path of the package
PKGDIR = __path__[0]
# Paths to check
_PATH1 = os.path.join(PKGDIR, '../foo')
_PATH2 = '/opt/foo'
if os.path.exists(_PATH1):
sys.path.append(_PATH1)
elif os.path.exists(_PATH2):
sys.path.append(_PATH2)
else:
raise ImportError('foo not found')
You must also add the contents of the other project's requirements.txt to your project. We do not attempt to resolve dependencies recursively as that is very difficult.
The bin/create_venv script prepares a virtualenv using a requirements.txt file.
$ bin/create_venv requirements.txt
The script will print the path to the virtualenv to stdout. Note that the output ends with a newline; Bash handles this, but Python does not.
To run the virtualenv Python, call bin/python under the virtualenv directory.
Together, this might look up:
$ venv=$(bin/create_venv requirements.txt)
$ ${venv}/bin/python
NOTE: It is not generally safe to run the other scripts in the virtualenv's bin directory due to hard-coded paths. Instead of running bin/pip for example, use bin/python -m pip.