tree 377d1ac0dd3e1190fe413f20bc0fb1edab233f12
parent f273848d7ab89804f20367afde9e1116819b7596
author Brian Norris <briannorris@chromium.org> 1603924933 -0700
committer Commit Bot <commit-bot@chromium.org> 1603950479 +0000

loman: realpath, not readlink

os.readlink() fails with "Invalid argument" if the path is not a
symlink.

loman: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/loman", line 181, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/loman", line 177, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 1038, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/loman.py", line 159, in main
    if os.path.basename(os.readlink(manifest_sym_path)) == 'minilayout.xml':
OSError: [Errno 22] Invalid argument: '/mnt/host/source/.repo/manifest.xml'

BUG=none
TEST=`cros-workon-${BOARD} start ...` on minilayout

Change-Id: Id4bbaa9816b847e008a7c0bf0f31b749c18ce325
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2506402
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>