tree 6c229abb513f58ece92a4b41c0162021d0766e48
parent b8ad8355b00a5381fddd4cb4c8157cc9b7157f89
author Mike Nichols <mikenichols@chromium.org> 1556844364 -0600
committer Mike Nichols <mikenichols@chromium.org> 1557180715 +0000

upload_symbols: Refactor error handling for duplicates

The retry logic does not handle custom exceptions therefore duplicate
file checks, which were thrown as handled exceptions, were falling
through and being thrown as HTTP exceptions.

Removed the custom exception and handled the duplicate check by setting
status if found.

BUG=chromium:956599
TEST='cros_sdk -- /mnt/host/source/chromite/run_tests'

Change-Id: I2343941db20759fe9277efbe04fc63221b32d385
Reviewed-on: https://chromium-review.googlesource.com/1593468
Commit-Ready: Mike Nichols <mikenichols@chromium.org>
Tested-by: Mike Nichols <mikenichols@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
(cherry picked from commit b03b2c67e067d7932d8b4aa97e3380d7daeee119)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1597132
Reviewed-by: David Burger <dburger@chromium.org>
Commit-Queue: Mike Nichols <mikenichols@chromium.org>