tree cf6938261e8b4df50bc2d977193b5d9d0dba92b1
parent 387002d1535da658f3dc7a55ad7815c2256d36f5
author Ned Nguyen <nednguyen@google.com> 1548958016 -0700
committer chrome-bot <chrome-bot@chromium.org> 1549030861 -0800

portage_util: remove usages of cros_build_lib.Die

Methods in chromite/libs/ shouldn't uses cros_build_lib.Die, the reason
is this raises SystemExit underneath & make us we lose all stack traces.

A potential cons of this is it may make some of the CLI reusing these
methods have uglier error messaging for the users. If this does happen
though, we can simply update the call sites in the CLI tools to do
try-catch & makes the error message more user-friendly.

BUG=chromium:917174
TEST=unittests

Change-Id: Id002893a433e64ae06884fbc6ee3957c27425394
Reviewed-on: https://chromium-review.googlesource.com/1447859
Commit-Ready: Ned Nguyen <nednguyen@google.com>
Tested-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>