commit c880a96581cf052799de536c7e6a25e65a5ffb29
author Mike Frysinger <vapier@chromium.org> Fri Nov 08 13:59:06 2013 -0500
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Mon Nov 18 17:53:41 2013 +0000
tree 566e62a41b686daed905d4b7b6f4874956ef72c2
parent 8f85d94d20052d093bfe1c39d79e0dc1263a0610

cros_setup_toolchains: rebuild libtool as needed

Whenever gcc upgrades, /usr/bin/libtool breaks because it hardcodes paths
to internal gcc paths.  For example, the current script has:
  sys_lib_search_path_spec="/usr/lib/gcc/x86_64-pc-linux-gnu/4.7.x-google /usr/lib64 /lib64 /usr/x86_64-pc-linux-gnu/lib "

So when we upgrade to gcc-4.8, that'll break and require manual cleanup.

Similarly, when we bootstrap the sdk, we switch from whatever gcc is in
the stage3 to our own version, and then libtool breaks.

BUG=chromium:313075
BUG=chromium:267982
TEST=`cbuildbot chromiumos-sdk` w/new stage3 no longer hit libtool errors
TEST=manually munged /usr/bin/libtool, ran `./update_chroot`, and saw libtool get rebuilt

Change-Id: I89115d509d226796e8c841487c98ba3def29cfc0
Reviewed-on: https://chromium-review.googlesource.com/176241
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

scripts/cros_setup_toolchains.py

diff --git a/scripts/cros_setup_toolchains.py b/scripts/cros_setup_toolchains.py
index 81619fc..a6ddb0a 100644
--- a/scripts/cros_setup_toolchains.py
+++ b/scripts/cros_setup_toolchains.py
@@ -332,6 +332,37 @@
 
 
 # Main functions performing the actual update steps.
+def RebuildLibtool():
+  """Rebuild libtool as needed
+
+  Libtool hardcodes full paths to internal gcc files, so whenever we upgrade
+  gcc, libtool will break.  We can't use binary packages either as those will
+  most likely be compiled against the previous version of gcc.
+  """
+  needs_update = False
+  with open('/usr/bin/libtool') as f:
+    for line in f:
+      # Look for a line like:
+      #   sys_lib_search_path_spec="..."
+      # It'll be a list of paths and gcc will be one of them.
+      if line.startswith('sys_lib_search_path_spec='):
+        line = line.rstrip()
+        for path in line.split('=', 1)[1].strip('"').split():
+          if not os.path.exists(path):
+            print 'Rebuilding libtool after gcc upgrade'
+            print ' %s' % line
+            print ' missing path: %s' % path
+            needs_update = True
+            break
+
+      if needs_update:
+        break
+
+  if needs_update:
+    cmd = [EMERGE_CMD, '--oneshot', 'sys-devel/libtool']
+    cros_build_lib.RunCommand(cmd)
+
+
 def UpdateTargets(targets, usepkg):
   """Determines which packages need update/unmerge and defers to portage.
 
@@ -518,6 +549,10 @@
   if deleteold:
     CleanTargets(targets)
 
+  # Now that we've cleared out old versions, see if we need to rebuild
+  # anything.  Can't do this earlier as it might not be broken.
+  RebuildLibtool()
+
 
 def ShowBoardConfig(board):
   """Show the toolchain tuples used by |board|