tree aae5ef5f453b81fcc34c0ec70a12f7b8d3d0c232
parent 124dbcdadbff9260d6f2adbca8b6c60a7a6b4d03
author Amin Hassani <ahassani@chromium.org> 1606170709 -0800
committer Commit Bot <commit-bot@chromium.org> 1606281293 +0000

cros_flash: Allow stateful payload not to be copied to device

Some devices have very limited size stateful partition. Currently, cros
flash is failing for such devices because cros flash copies the payloads
into the DUT first before updating the device. Hence, the lack of space
problem. This CL adds a new flag --no-copy-payloads-to-device that if
passed the stateful update payload is not copied to the device first,
rather it is piped to the 'tar' command that untars the stateful update.

This approach in theory should make cros flash faster because it
eliminates one disk write and one disk read. However, experiments shows
that this flag makes cros flash slower but about 10-15 seconds (for a
electro device). Probably, the reason could be how inefficient the piped
file is read by the tar command. Hence, we decided not to enable this
option by default.

BUG=b:170359436
TEST=cros flash --no-ping <dut-ip> latest/reef/test
TEST=cros flash --no-ping --no-copy-payloads-to-device <dut-ip> latest/reef/test

Change-Id: Iecfbf3460bb4c48918edf63045d8372d7170cfc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2555531
Tested-by: Amin Hassani <ahassani@chromium.org>
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Auto-Submit: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>