Remove incorrect Return True. Nothing uses the output of this function anyway.
BUG=chromium-os:20173
TEST=Unittest
Change-Id: I40028fda69e3c4588e1e61f49e01e439d8efb7a3
Reviewed-on: http://gerrit.chromium.org/gerrit/7388
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Ryan Cui <rcui@chromium.org>
diff --git a/buildbot/validation_pool.py b/buildbot/validation_pool.py
index 6cb479d..c9b2f17 100644
--- a/buildbot/validation_pool.py
+++ b/buildbot/validation_pool.py
@@ -166,8 +166,6 @@
def SubmitPool(self):
"""Commits changes to Gerrit from Pool.
- Returns:
- True if we were able to do submit the changes.
Raises:
TreeIsClosedException: if the tree is closed.
"""
@@ -180,7 +178,6 @@
change.HandleCouldNotSubmit(self.gerrit_helper,
dryrun=self.dryrun)
# TODO(sosa): Do we re-raise?
- return True
else:
raise TreeIsClosedException()
diff --git a/buildbot/validation_pool_unittest.py b/buildbot/validation_pool_unittest.py
index d494a99..ace6b96 100755
--- a/buildbot/validation_pool_unittest.py
+++ b/buildbot/validation_pool_unittest.py
@@ -1,3 +1,5 @@
+#!/usr/bin/python
+
# Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
