| commit | 6d0c0ffef52928a9c35402604505e3a985627857 | [log] [tgz] |
|---|---|---|
| author | Stephanie Kim <kimstephanie@google.com> | Tue Jan 26 22:55:56 2021 +0000 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 26 22:55:56 2021 +0000 |
| tree | 85057421e6d16fd019c2cbc4cbb278c4c88971dd | |
| parent | 76d0e6aca79faa718a06a7afb16335386eb582d6 [diff] |
Add previous_got_revision and previous_got_revision_cp to output As chrome browser infra works to improve CQ times, we would like to easily glance at builds and see how many new commits were checked out. Currently you have to open up bot_update stdout to see the previous HEAD revision and go from there. Having this conveniently outputted would be very convenient. If the bot has previously checked out the repo, output which revision and commit position were checked out. example LED build showing new output: https://ci.chromium.org/swarming/task/51592e46d6a70e10?server=chromium-swarm.appspot.com Change-Id: Ib8a6f152a593446ce4082477bc9ada44f1fd1fc3 Bug: 1170568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644829 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.