commit | b7ed76a09d1953d75968cbc14a53f724c11fb5f9 | [log] [tgz] |
---|---|---|
author | Jiewei Qian <qjw@chromium.org> | Fri Apr 19 06:22:07 2024 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 19 06:22:07 2024 +0000 |
tree | 2ab8860dd93e4dc9d593f6431170cf72c4984446 | |
parent | 1a61eb625d4b062bb2d6f0902b4979b48def4d33 [diff] |
metadata: define a clear DependencyMetadata interface This CL adds a typed interface that exposes parsed metadata for downstream consumption. Conventionally: - A validated field should be retrieved by the property of the same name - A validated field returns "None" if said field is not provided, or is clearly invalid (e.g. "Unknown" values) - Raw values can still be retrieved with get_entries() When using the properties accessor, fields are normalized and/or coerced to a suitable type (e.g. list of str, str of a particular format). Bug: b/321154076 Change-Id: Ia56969a838e682a7b7eb1dc0781d48e1e38a2ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5446637 Reviewed-by: Rachael Newitt <renewitt@google.com> Commit-Queue: Jiewei Qian <qjw@chromium.org>
Tools for working with Chromium development. It requires python 3.8.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.