commit | f79e432021a1c1a27dcf0d6a3e6829b72cc961b7 | [log] [tgz] |
---|---|---|
author | Yoshisato Yanagisawa <yyanagisawa@google.com> | Fri Jan 15 10:24:02 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 15 10:24:02 2021 +0000 |
tree | 11605dbc91bb3bd58fb74dbef249629e63032f42 | |
parent | 091f5ac0a64ce66b75c185eb0ee698ef4e837145 [diff] |
Revert "Avoid capture_output to support Python 3.6" This reverts commit 2241db8a1f6c05325c8a0c9eb5426d96cd6fa984. Reason for revert: Cannot merge https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018 due to conflict. Original change's description: > Avoid capture_output to support Python 3.6 > > autoninja.py uses subprocess.run which requires Python 3 and used > capture_output which requires Python 3.6. One user reported this as an > issue and it turns out that it is easy to avoid by using subprocess.NULL > which then means that Python versions back to 3.3 are supported. > > Bug: 868590, b/174673874 > Change-Id: Ife5e186d9c54747d35ff989dc2afadba5b9a57f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2630525 > Auto-Submit: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> TBR=justincohen@chromium.org,brucedawson@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5131a43eeb9410a6b45920d409a392a2df9d9af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868590 Bug: b/174673874 Bug: 1167064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632022 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.