commit | ec709593d585f1834b8a3933fd8a4696f457ca16 | [log] [tgz] |
---|---|---|
author | Wenhan (Han) Zhang <zwenhan@google.com> | Thu Aug 13 22:18:52 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 13 22:18:52 2020 +0000 |
tree | 0e45a769ec439e65d608f05141d036a0d03aa5b4 | |
parent | 7e01e26874d3b6e1d6449c872122800667d81451 [diff] |
Revert "Modified git cl format for distributed histograms" This reverts commit 7497bb4edd4245602c6ed7238f08bc407ad1f8ed. Reason for revert: This should be landed after https://chromium-review.googlesource.com/c/chromium/src/+/2339216 is landed, where pretty_print.py in histograms/ will require a path argument. Original change's description: > Modified git cl format for distributed histograms > > If files in histograms folder are changed, pretty_print.py will be run on every > XML file changed and it will take in an additional relative path argument since > histograms are split up by prefixes. > > Change-Id: I6902de2079edbb3bf17858ea93fb26d49a28fb37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340139 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> TBR=holte@chromium.org,sweilun@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com,zwenhan@google.com Change-Id: I40ae8b933795c746e19e5a489a8c39ba2c59e693 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2353072 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.