commit | e95b5d6ad52be5b149cecf274905e1aa9ea59a6f | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Mon Aug 24 20:00:34 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 24 20:00:34 2020 +0000 |
tree | 6e8068dcd127b17d6d8620d95bb92ddd373f8dc3 | |
parent | f0e672e73260f8e5c89f6dd2eb78056a59dcd0bc [diff] |
Avoid ..\.. in packaged environment variables win_sdk\bin\setenv.cmd is used to configure the build environment for the packaged toolchain. This has always been done by creating paths such as %~dp0..\..\VC, which leads to extra long paths that are less readable than direct paths. These extra long paths make us more vulnerable to MAX_PATH issues. This change generates the paths relative to the grandparent directory. It does that by changing the current directory to the grandparent directory of the script and then generating paths relative to %cd%. The paths are still absolute they are just shorter and simpler. The paths are also stored in SetEnv.*.json and this change alters the relative-root used for these paths. crrev.com/c/2370604 detects the needed relative-root to handle toolchains packaged before and after this change. This change was tested using crrev.com/c/2370604 (temporarily modified to use a toolchain created by this change) to ensure that it works. Bug: 1120785 Change-Id: Icd72e36766d7ec92a491d16dbfd9ad7fc1b2ebc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2372727 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.