commit | e7dc8c3a863ce0cf24523431ae8ae535b237ece8 | [log] [tgz] |
---|---|---|
author | Fumitoshi Ukai <ukai@google.com> | Mon Mar 15 02:00:29 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 15 02:00:29 2021 +0000 |
tree | 3899786dd1aceec2717cd497c0368e317a0ec04a | |
parent | 159efcaed76e07cb9698982ce5a55d5c6b773d16 [diff] |
Revert "Make autoninja.py work again w/ Python3 and MSYS/MinGW bash." This reverts commit 9e2dfdcc821ca358bd862bcdada3f1f4de8b261c. Reason for revert: build failure https://chrome-internal-review.googlesource.com/c/goma/client/+/3683303 e.g. https://ci.chromium.org/ui/p/goma-client-internal/builders/try/Goma%20Trusty64%20Presubmit/b8852734992897102240/overview https://logs.chromium.org/logs/goma-client-internal/buildbucket/cr-buildbucket.appspot.com/8852734992897102240/+/steps/build/0/stdout /b/s/w/ir/kitchen-checkout/depot_tools/autoninja: line 11: /b/s/w/ir/kitchen-checkout/depot_tools/python-bin/python3: No such file or directory /b/s/w/ir/kitchen-checkout/depot_tools/autoninja: line 20: /b/s/w/ir/kitchen-checkout/depot_tools/python-bin/python3: No such file or directory /b/s/w/ir/kitchen-checkout/depot_tools/autoninja: line 30: /b/s/w/ir/kitchen-checkout/depot_tools/python-bin/python3: No such file or directory Original change's description: > Make autoninja.py work again w/ Python3 and MSYS/MinGW bash. > > We switched autoninja.py to python3 in https://crrev.com/c/2752772 > but that assumes `python3` is in $PATH (which is likely true on > Mac and Linux but less likely to be true on Windows, especially > in MSYS/MinGW/git bash shells. > > It's safer to use the `python3` bundled into depot_tools in > `$depot_tools/python-bin` and more hermetic to boot. > > Bug: 1187609 > Change-Id: I65efd1a2b87135ac4e25ba377309c3374cfda085 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2756889 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1187609 Change-Id: I07b04d615624d3dc6bc071920ec97ed39583b64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2758609 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.