commit | e65444f91de0d3c8c5f5e9e40df1598fcbf91e05 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Wed Jun 03 23:21:41 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 03 23:21:41 2020 +0000 |
tree | ec744acf1c8be1033a1dec25925c2b7d524aa41c | |
parent | 84620d395a4d776f393a3c121544ff0b9b9c1c71 [diff] |
Fix Python3 bugs in package_from_installed.py The package_from_installed.py script didn't run under Python 3. This change fixes that and this script now _requires_ Python 3. Requiring Python 3 was simpler than supporting both, and there is no need to maintain Python 2.7 support. This script is only ever invoked manually and all machines it is run on should have Python 3. Changes included using universal_newlines=True so that subprocess.check_output returns a string instead of bytes, and by explicitly converting dict.items() to a list. Similarly, open(name, 'wb') was changed to open(name,'wt', newline='') to avoid byte/str problems while still avoiding CR/LF translations. This also changes the default Windows 10 SDK version to something more recent - the current version that we build with. To test: python3 package_from_installed.py -d 2019 The use of '-d' makes the script run in test mode which is much faster. Change-Id: I2e3fc4d464f2914ba5ae36f0a78570ea7e5d4f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2224506 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.