commit | e64cd3aeff711420369d8daf2a60006045591622 | [log] [tgz] |
---|---|---|
author | Nico Weber <thakis@chromium.org> | Wed Jul 08 18:54:02 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 08 18:54:02 2020 +0000 |
tree | 2d68f5ee14410d78f3565f435c7e3631d08e2476 | |
parent | c49c88ac82fb8dc94ed366527c8bd8b9fa84e3fa [diff] |
mac: Add an arm64 slice to ninja-mac. To build the arm ninja binary, I downloaded a zip with the ninja 1.8.2 code, and ran `./configure --bootstrap` on an arm mac, with Xcode 12 beta installed, followed by `strip ninja`. That gave me a working ninja 1.8.2 arm binary. I then copied it to my intel mac and ran lipo -create -output ninja-mac ninja-mac ~/Downloads/ninja to make a fat binary. No intended behavior change on non-arm macs. (This means the x86_64 slice, which is the previously existing binary, has a LC_VERSION_MIN_MACOSX version 10.6, while the arm64 slice has LC_BUILD_VERSION minos 11.0, according to `otool -arch ax86_64 -l ninja-mac` and `otool -arch arm64 -l ninja-mac`.) Bug: 1103315,762354 Change-Id: I2c4bea53a01d7a6135f9cd5554e3123dba960664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2288417 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.