commit | d410c664e6e371f8b2ba32be75de2c4adfea3fb9 | [log] [tgz] |
---|---|---|
author | Ben Pastene <bpastene@chromium.org> | Wed Aug 26 17:07:03 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 26 17:07:03 2020 +0000 |
tree | 0cbcb836c5a53872c3d16db1103dc562da27fdf9 | |
parent | c6aa15118046ed881094f1d97061bdb92ba7a149 [diff] |
gclient: Preserve ANSI color codes when calling hooks. If a hook prints error/warning output that's color-coded, gclient will cause the coloring to be disabled since those hooks aren't called directly from a terminal. By emulating a terminal when launching subprocs from gclient, we can convince them to keep the color escape codes. LED builds with both //third_party/depot_tools rolled to this CL, as well as depot_tools in the recipe bundle rolled to this CL: linux: https://ci.chromium.org/swarming/task/4e40237985888310 mac: https://ci.chromium.org/swarming/task/4e4023ea0c829710 win: https://ci.chromium.org/swarming/task/4e4024612e03dc10 Bug: 1034063 Change-Id: I4150f66ef215ece06f4c32482dcd4ded14eb1bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2368435 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.