commit | cd71dafbf06dfd0a11f582af155f452290b566a7 | [log] [tgz] |
---|---|---|
author | Josip Sokcevic <sokcevic@google.com> | Tue Mar 02 22:28:11 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 02 22:28:11 2021 +0000 |
tree | cc90a40db8cd3939a38683725ec51a4bab50d32b | |
parent | ea65b8412ba9605fce2eb19b16bfd135b7297aca [diff] |
Revert "presubmit: Fix checking if code-owners enabled for repo." This reverts commit 70405c2f9f3e0a5f2a99b888a1bf3d56da74c7c8. Reason for revert: doesn't work with depot_tools error 404 Not found: tools Bug: 1183975 Original change's description: > presubmit: Fix checking if code-owners enabled for repo. > > Change-Id: I22e6a9d4405d92d26dfbfba64735b6e9ce92674c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729404 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Change-Id: Ib358f31e7c4c6fc07f98db4758004097234eaa87 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729408 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.