commit | cc29098042868c6b833efa40c09762f8c4be326b | [log] [tgz] |
---|---|---|
author | Shahbaz Youssefi <syoussefi@chromium.org> | Mon Sep 21 20:40:18 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 21 20:40:18 2020 +0000 |
tree | 728492b08546169f85cd4408fca346b62b5e43df | |
parent | e0244d9798abf742edb345f6cb76b67685fd45f4 [diff] |
Strip trailing empty lines when getting footers Take the following git change description (Note: added ~ to avoid having these lines be parsed as tags): ``` ~Test ~ ~Bug: something ~Change-Id: Something ``` Sometimes(?) `git log --pretty=format:%B%n <hash>..` returns: ``` ~Test ~ ~Bug: something ~Change-Id: Something ``` The trailing empty line trips split_footers() up, making it return an empty footer. This change removes trailing empty lines before processing them. Bug: 1130601 Change-Id: Ib8d6c37ad6817a47a744245d1a2455ac9af6c469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2422378 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.