commit | c8c88f9c557b3096468cda4271aaa07ee7b9c6a2 | [log] [tgz] |
---|---|---|
author | Garrett Beaty <gbeaty@chromium.org> | Wed Jul 22 15:47:14 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 22 15:47:14 2020 +0000 |
tree | 850fd81ea4e68c13201989cff72c4fed1318f615 | |
parent | 33e6e046e0e3a1c986c35e40ce509b1e1a135528 [diff] |
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.