commit | c6aa15118046ed881094f1d97061bdb92ba7a149 | [log] [tgz] |
---|---|---|
author | Josip Sokcevic <sokcevic@google.com> | Tue Aug 25 23:47:13 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 25 23:47:13 2020 +0000 |
tree | db828c22b954361e4656b3d0889886e483f60e94 | |
parent | dff2104727dc207f58d87b938e04402be548329c [diff] |
Warn only if non-inclusive term is used This fixes the issue where presubmit_canned_checks issues a warning if optional arguments in CheckAuthorizedAuthor are not used at all. This relands commit b09f2bb2f282727b3316c30659e2998ac4f1a373 with some additional changes. R=apolito@google.com Bug: 1098560 Change-Id: If323d90ab7d6bcca68ed89142ea67edc4be057d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2373216 Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.