tree 5be6fd2b6a37fc973dbc06104d1984806ad6c757
parent 97adc5795ed2d186d4e15eb5ede4e97bb1a0c6b1
author Saagar Sanghavi <saagarsanghavi@google.com> 1597185685 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> 1597185685 +0000

New approach for timing lower-level checks

Use input_api.version and PRESUBMIT_VERSION to ensure newest versions.

Enable presubmit_support to time/ResultDB wrap each individual
lower-level check in PRESUBMIT.py. The approach taken here is to have
the PRESUBMIT_VERSION = 2.0.0 in PRESUBMIT.py
so that presubmit_support is aware of the new version of PRESUBMIT.py,
then check input_api.version in CheckChangeOnCommit/Upload to ensure
that presubmit_support itself is the new version.


Once these changes are landed, the associated changes in PRESUBMIT.py
(crrev.com/c/2350234) can landed as well.


Change-Id: If6d5e318547bc4f128ffe151387c4dc339ef5dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2349979
Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>