commit | 8f6bfe301f308c25a95ce5032f521decefa0a01b | [log] [tgz] |
---|---|---|
author | Josip Sokcevic <sokcevic@google.com> | Wed May 20 23:23:16 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 20 23:23:16 2020 +0000 |
tree | f31ad76cb31227f45088305a84c692e0f9c4788a | |
parent | 7aed4bb802bd48ab15c6b4f1cb6459a1e42d2b4d [diff] |
Revert "Use OS level locking in git_cache.py" This reverts commit d3affaa62488e0d67e04f810f1c2f2f40793e06b. Reason for revert: no attribute ignore_lock Original change's description: > Use OS level locking in git_cache.py > > Without OS level locking it's possible to leave "lock" files on disk > which will prevent next run to acquire those locks. This can easily > happen if SIGKIL is issued. > > R=apolito@google.com, ehmaldonado@chromium.org > > Bug: 1049610 > Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> TBR=iannucci@chromium.org,ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: Iecc963e0a99d7f59f3f8801e529839346f9fbaf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211186 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.