commit | 8a0efc1862af945f7889c4739f6023d705f33c75 | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Wed Aug 05 19:58:45 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 05 19:58:45 2020 +0000 |
tree | 2d15cd4222c80728b5b26aee2f99ea83e1f7cc8c | |
parent | fb9c1110ef1460f5dbb3cb57cce3fc6f977abcff [diff] |
Handle BUG_PREFIX correctly when populating Bug: lines. Right now git_cl.py inserts an extra colon if the bug prefix ends with a colon. Fix this by detecting whether the bug prefix ends with a colon or not, and only inserting the colon when necessary. Bug: 1111955 Change-Id: I3db199435087abb17b9600fc208b11d2d8e6a615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2333426 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.