commit | 8351dc1fb7c4eb1858096c51ffe3f45754877cb0 | [log] [tgz] |
---|---|---|
author | Ben Pastene <bpastene@chromium.org> | Thu Aug 06 05:01:35 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 06 05:01:35 2020 +0000 |
tree | 28edd71d82a2a3620c1c20b6541b292433cf47c1 | |
parent | b932a7fed903e1e9979591351c2a87b9724421e2 [diff] |
Revert "[Fixed from older branch] Timing/RDB for lower-level checks" This reverts commit dba1d65a1999dc08fc68bd734fa414ecd4fe27bd. Reason for revert: "Check* takes exactly 3 arguments (2 given)" presubmit errors eg: https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/933062? https://crbug.com/1113506 Original change's description: > [Fixed from older branch] Timing/RDB for lower-level checks > > presubmit: Report timing to rdb for individual checks > Rather than using CheckChangeOnCommit() or CheckChangeOnUpload() as the > sole entry points for PRESUBMIT.py files, this cl enables presubmit_support.py > to use any CheckXYZ[OnCommit/Upload] function to serve as an entry point. > > This way, we can perform timing and RDB reporting for each of the > presubmit check functions and have check-specific data. > > Bug: 1106943 > Change-Id: Ifdabd68c0904a6d70a828f12de157369c6c1571d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2332321 > Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> TBR=dpranke@google.com,estaab@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,saagarsanghavi@google.com Change-Id: Ibd80f70661d2196f903f0c6b79eb74eda6c94d44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106943, 1113506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2340692 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.