commit | 7872beb4896330a06038248cbac312da29304bcc | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Tue Aug 25 21:10:31 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 25 21:10:31 2020 +0000 |
tree | 33ff12c3e546bce394e61c2a934ac8236132cd54 | |
parent | b09f2bb2f282727b3316c30659e2998ac4f1a373 [diff] |
Shorten hash to avoid MAX_PATH limits The Windows SDK contains some very long paths. When those are added to the 40-character hash directory and the other path components it is easy to hit the Windows 260-character MAX_PATH limit. In addition, the 40 character hash makes paths unwieldy in VsChromium search results and elsewhere. A ten character hash should be more than enough to avoid collisions - if we upload a million toolchain packages then there will be about a 50% chance of a name collision - we won't upload more than a thousand. This was tested by copying the current toolchain file on Google storage to a truncated name and then changing to that hash in vs_toolchain.py. It was also necessary to copy the updates from depot_tools to third_party\depot_tools. This means that we can't actually start using short hashes until depot_tools has rolled. We probably won't use a shorter hash until we next roll the toolchain, just because changing the toolchain hash is mildly disruptive. Bug: 1120785 Change-Id: I878b058857cbe9cb72a72b535864404eede33f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2376030 Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.