commit | 655afebfcd133e224e8a35f43acbc43dbdaf61af | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Mon Nov 02 23:30:37 2020 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 02 23:30:37 2020 +0000 |
tree | 122d409ad2f936cac0bc6148fe83679821058000 | |
parent | 9396c2b0646a73f3cbe53b06424c53bddb8064d3 [diff] |
Support autoninja -o/--offline to disable goma It is sometimes helpful to do a full build of Chrome using goma while online and then do incremental builds without goma while offline or with poor network bandwidth. Turning off goma in gn args triggers a full rebuild but the GOMA_DISABLED environment variable can be used to disable goma without triggering a rebuild. In order to make this feature easier to discover and use this change adds support for -o/--offline to autoninja. autoninja -h will mention this flag and autoninja.bat/autoninja.py handle it appropriately. This means setting the environment variable in autoninja.bat, and using it to adjust the -j value and stripping it out in autoninja.py. The bash script that wraps autoninja.py on Linux and OSX did not need updating because the Python script can emit 'GOMA_DISABLED=1 ninja ...' and this is executed by bash. This was produced during pair programming with jessemckenna@ Bug: b/172039612 Change-Id: Ifcfbc598ac20f23e5fe013e02979b5b8c2851b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2510818 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.