Google Git
Sign in
cos / mirrors / cros / chromium / tools / depot_tools / 57ed3aedaef3e9eabf9d8ea19f99ebbe8925b7be
commit57ed3aedaef3e9eabf9d8ea19f99ebbe8925b7be[log] [tgz]
authorMichael Moss <mmoss@google.com>Tue Oct 08 01:45:34 2019 +0000
committerMichael Moss <mmoss@chromium.org>Tue Oct 08 01:45:34 2019 +0000
tree05191623b0da8cdaf36c55da99801b64cf2fc8d3
parente3614ad6f574a554f18dbcb1c03dd9f0df6ab3ba [diff]
Run git_cl commands as a python step.

Otherwise this fails on Windows because git_cl.py "is not a valid Win32
application".

R=​gbeaty@google.com, iannucci@google.com

Bug: 726111
Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349

Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835598
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
(cherry picked from commit 6b4c2a88f36eba12106e899b19c54c7b1d51b793)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846782
Reviewed-by: Michael Moss <mmoss@chromium.org>
4 files changed
tree: 05191623b0da8cdaf36c55da99801b64cf2fc8d3
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. recipes/
  7. support/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ support/chromite_wrapper
  14. chrome_set_ver ⇨ support/chromite_wrapper
  15. cros ⇨ support/chromite_wrapper
  16. cros_sdk ⇨ support/chromite_wrapper
  17. .gitattributes
  18. .gitignore
  19. .style.yapf
  20. .vpython
  21. annotated_gclient.py
  22. appengine_mapper.py
  23. auth.py
  24. autoninja
  25. autoninja.bat
  26. autoninja.py
  27. bb
  28. bb.bat
  29. breakpad.py
  30. buildbucket.py
  31. checkout.py
  32. cipd
  33. cipd.bat
  34. cipd.ps1
  35. cipd_bin_setup.bat
  36. cipd_bin_setup.sh
  37. cipd_client_version
  38. cipd_client_version.digests
  39. cipd_manifest.txt
  40. cipd_manifest.versions
  41. cit
  42. cit.bat
  43. cit.py
  44. clang-format
  45. clang-format.bat
  46. clang_format.py
  47. clang_format_merge_driver
  48. clang_format_merge_driver.bat
  49. clang_format_merge_driver.py
  50. codereview.settings
  51. compile_single_file
  52. compile_single_file.bat
  53. compile_single_file.py
  54. cpplint.bat
  55. cpplint.py
  56. cpplint_chromium.py
  57. CROS_OWNERS
  58. dart_format.py
  59. depot-tools-auth
  60. depot-tools-auth.bat
  61. depot-tools-auth.py
  62. detect_host_arch.py
  63. download_from_google_storage
  64. download_from_google_storage.bat
  65. download_from_google_storage.py
  66. ensure_bootstrap
  67. fetch
  68. fetch.bat
  69. fetch.py
  70. fix_encoding.py
  71. gclient
  72. gclient-new-workdir.py
  73. gclient.bat
  74. gclient.py
  75. gclient_completion.sh
  76. gclient_eval.py
  77. gclient_paths.py
  78. gclient_scm.py
  79. gclient_utils.py
  80. gerrit_client.py
  81. gerrit_util.py
  82. git-cache
  83. git-cl
  84. git-crrev-parse
  85. git-drover
  86. git-find-releases
  87. git-footers
  88. git-freeze
  89. git-gs
  90. git-hyper-blame
  91. git-map
  92. git-map-branches
  93. git-mark-merge-base
  94. git-nav-downstream
  95. git-nav-upstream
  96. git-new-branch
  97. git-number
  98. git-rebase-update
  99. git-rename-branch
  100. git-reparent-branch
  101. git-retry
  102. git-runhooks
  103. git-squash-branch
  104. git-thaw
  105. git-upstream-diff
  106. git_cache.py
  107. git_cl.py
  108. git_cl_completion.sh
  109. git_common.py
  110. git_dates.py
  111. git_drover.py
  112. git_find_releases.py
  113. git_footers.py
  114. git_freezer.py
  115. git_hyper_blame.py
  116. git_map.py
  117. git_map_branches.py
  118. git_mark_merge_base.py
  119. git_nav_downstream.py
  120. git_new_branch.py
  121. git_number.py
  122. git_rebase_update.py
  123. git_rename_branch.py
  124. git_reparent_branch.py
  125. git_retry.py
  126. git_squash_branch.py
  127. git_upstream_diff.py
  128. gn
  129. gn.bat
  130. gn.py
  131. gsutil.py
  132. gsutil.py.bat
  133. gsutil.vpython
  134. led
  135. led.bat
  136. LICENSE
  137. luci-auth
  138. luci-auth.bat
  139. lucicfg
  140. lucicfg.bat
  141. mac_toolchain
  142. metrics.py
  143. metrics.README.md
  144. metrics_utils.py
  145. my_activity.py
  146. ninja
  147. ninja-linux32
  148. ninja-linux64
  149. ninja-mac
  150. ninja.exe
  151. ninjalog.README.md
  152. ninjalog_uploader.py
  153. ninjalog_uploader_wrapper.py
  154. OWNERS
  155. owners.py
  156. owners_finder.py
  157. patch.py
  158. post_build_ninja_summary.py
  159. PRESUBMIT.py
  160. presubmit_canned_checks.py
  161. presubmit_support.py
  162. profile.xml
  163. prpc
  164. prpc.bat
  165. pylint
  166. pylint.py
  167. pylintrc
  168. python_runner.sh
  169. README.gclient.md
  170. README.git-cl.md
  171. README.md
  172. repo
  173. roll-dep
  174. roll-dep-svn
  175. roll-dep-svn.bat
  176. roll-dep.bat
  177. roll_dep.py
  178. roll_dep_svn.py
  179. scm.py
  180. setup_color.py
  181. split_cl.py
  182. subcommand.py
  183. subprocess2.py
  184. update_depot_tools
  185. update_depot_tools.bat
  186. update_depot_tools_toggle.py
  187. upload_metrics.py
  188. upload_to_google_storage.py
  189. vpython
  190. vpython.bat
  191. watchlists.py
  192. weekly
  193. wtf
  194. yapf
  195. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.