commit | 4ec3fd3659ccd4fc7e1f977ee9361caf38635e91 | [log] [tgz] |
---|---|---|
author | Takuto Ikuta <tikuta@chromium.org> | Fri Mar 05 06:02:58 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 05 06:02:58 2021 +0000 |
tree | 54f6d5964198e3a106ad37b606df52a4fb425e92 | |
parent | 20815505e6008a33adec35bad46e589d4a8386cb [diff] |
Revert "Modify fix_encodng to make it use fix_win_sys_argv for python2 only and" This reverts commit 20815505e6008a33adec35bad46e589d4a8386cb. Reason for revert: This is not necessary after https://crrev.com/c/1929653 Original change's description: > Modify fix_encodng to make it use fix_win_sys_argv for python2 only and > not for python3 on windows. > > The function works around <https://bugs.python.org/issue2128>, and the bug is fixed for python3 now. > > Bug: 1182016 > Change-Id: I3880843b109d5b9779e5bbd1e39a3132f925ecc4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738234 > Commit-Queue: Momo Sasaki <momosasaki@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Junji Watanabe <jwata@google.com> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Bug: 1182016 Change-Id: I153640b174a78990e39b3597208b6785003ca321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2738936 Reviewed-by: Junji Watanabe <jwata@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.