commit | 499a2fd61be35184c4b4bf23caf5eee06d12fb27 | [log] [tgz] |
---|---|---|
author | Nico Weber <thakis@chromium.org> | Tue Feb 02 14:36:07 2021 +0000 |
committer | Nico Weber <thakis@chromium.org> | Tue Feb 02 14:36:07 2021 +0000 |
tree | 87dc5fe1702dcbb9dbf3b11c37946693b269760b | |
parent | 8bb3513349f314da3001e0c3baac527a64a92e7f [diff] |
Reland "win toolchain: Prepare downloader for windows sdk dir switch" This is a reland of e72789f5b4e6e96a6c114133eb7d147da6be656b Original change's description: > win toolchain: Prepare downloader for windows sdk dir switch > > crrev.com/c/2655836 tries to move the Windows SDK from > "win_sdk" to "Windows Kits/10". > > get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to > third_party/depot_tools/win_toolchain/data.json which then gets copied > by a script in the chromium repo to build/win_toolchain.json. > For the SDK move to work, chromium's pinned depot_tools > must write the new SDK path when rolling in the new toolchain package. > This change makes depot_tools handle win packages that have the > windows sdk either win "win_sdk" or in "Windows Kits\10". > > The plan is: > > 1. Land this change, which can handle both path styles > 2. Wait for depot_tools in chromium to update > 3. Then roll to a win toolchain package with the new layout > > In a few years, when we no longer need the old layout, > we can remove this detection code again and assume the new layout. > > Bug: 1173176 > Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Bug: 1173176,1173393 Change-Id: Ic706f694f8f0260208fa637864e62d7cc4f7ce93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2668127 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.