commit | 428143ee24c5f084c8dfb38cd17f07b4f7ba9bf7 | [log] [tgz] |
---|---|---|
author | Yoshisato Yanagisawa <yyanagisawa@google.com> | Fri Jan 15 10:24:48 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 15 10:24:48 2021 +0000 |
tree | fe21435e5e562eb169394afd717315d48181fed8 | |
parent | f79e432021a1c1a27dcf0d6a3e6829b72cc961b7 [diff] |
Revert "Check whether goma is running when it is enabled" This reverts commit b7ddc5a0091bcd4d070fcd91027d7099338e84b9. Reason for revert: This broke the builder where depot_tools is not in PATH. https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858077852309878080/+/u/build/stdout Original change's description: > Check whether goma is running when it is enabled > > One of the mistakes one can make when running ninja is having goma > enabled (use_goma=true in args.gn) but not having goma running. This can > lead to ~1,000 failed compile steps, which is messy. > > This change teaches autoninja.py to check whether goma is running. If > not then it tells autoninja to just print a warning message. The > check costs roughly 30 ms which seems reasonable. > > In fact, because this change also switches away from vpython (necessary > to use python3 to use subprocess.run) it actually runs about 600 ms > _faster_ than before this change. > > If build acceleration is requested through use_rbe then no checking for > whether the service is running is done. That could be added in the > future. > > autoninja.py could auto-start goma but that is error prone and has > limited additional value. > > This was tested on Linux, OSX, and Windows. > > Bug: 868590, b/174673874 > Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I57a6c73ea853259f3d1ec7ad0ce51e495acc96db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868590 Bug: b/174673874 Bug: 1167064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.