commit | 48492322a07d8c42bee0c63bf97490bdf8cc669f | [log] [tgz] |
---|---|---|
author | Edward Lesmes <ehmaldonado@chromium.org> | Wed Mar 17 16:47:09 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 17 16:47:09 2021 +0000 |
tree | 66690b63808e6c0b0bafb078fcceccfd6cdf4dba | |
parent | 36de4be91ef66852c49aa5fd9e0cc31d5ec05ae9 [diff] |
Revert "presubmit: Use code-owners plugin if available." This reverts commit 36de4be91ef66852c49aa5fd9e0cc31d5ec05ae9. Reason for revert: Not working for v8: crbug.com/1189233 Original change's description: > presubmit: Use code-owners plugin if available. > > Change-Id: I56734de985731d007360a4a4e65f2b16de28b69a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2753894 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Bug: 1189233 Change-Id: Id96277e1a6d3b9dcf5fc1bf4816706515b75e55c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2767720 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.