Google Git
Sign in
cos / mirrors / cros / chromium / tools / depot_tools / 1607bf453ae1248e3209b2b9a25dd05d1e413e0b
commit1607bf453ae1248e3209b2b9a25dd05d1e413e0b[log] [tgz]
authorMatt Kotsenas <mattkot@microsoft.com>Wed Nov 11 21:28:48 2020 +0000
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 11 21:28:48 2020 +0000
treee3dc5930df9701cd5181342ce69f76349a1c34db
parentc135bfa0f44f7cf57b6971ce43fdb4e7a255b981 [diff]
Retry CIPD client download on Linux / macOS

Transient network conditions can cause the CIPD client download to fail,
so add a retry to the download.

When using `wget` we additionally retry usually fatal errors like
"connection refused" via `--retry-connrefused`. `curl` also has that
parameter, but it was added more recently in version 7.52.0, which isn't
available on supported platforms like Ubuntu 16.04. Once we raise the
minimum supported version of curl, we should add that parameter as well.

In either case, we retry 3 times and wait 5 seconds between each try,
which matches the retries recently added for Windows.

Bug: 1145741
Change-Id: Ib73bb3413ba4d5251c2b027a87dabd1378ab6c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2532896
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Matthew Kotsenas <mattkot@microsoft.com>
1 file changed
tree: e3dc5930df9701cd5181342ce69f76349a1c34db
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. python-bin/
  7. recipes/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ cros
  14. chrome_set_ver ⇨ cros
  15. cros_sdk ⇨ cros
  16. .cipd_impl.ps1
  17. .gitattributes
  18. .gitignore
  19. .style.yapf
  20. .vpython
  21. .vpython3
  22. auth.py
  23. autoninja
  24. autoninja.bat
  25. autoninja.py
  26. bb
  27. bb.bat
  28. bootstrap_python3
  29. breakpad.py
  30. cipd
  31. cipd.bat
  32. cipd_bin_setup.bat
  33. cipd_bin_setup.sh
  34. cipd_client_version
  35. cipd_client_version.digests
  36. cipd_manifest.txt
  37. cipd_manifest.versions
  38. cit
  39. cit.bat
  40. cit.py
  41. clang-format
  42. clang-format.bat
  43. clang_format.py
  44. clang_format_merge_driver
  45. clang_format_merge_driver.bat
  46. clang_format_merge_driver.py
  47. codereview.settings
  48. compile_single_file
  49. compile_single_file.bat
  50. compile_single_file.py
  51. cpplint.bat
  52. cpplint.py
  53. cpplint_chromium.py
  54. cros
  55. CROS_OWNERS
  56. crosjobs
  57. detect_host_arch.py
  58. dirmd
  59. dirmd.bat
  60. download_from_google_storage
  61. download_from_google_storage.bat
  62. download_from_google_storage.py
  63. ensure_bootstrap
  64. fetch
  65. fetch.bat
  66. fetch.py
  67. fix_encoding.py
  68. gclient
  69. gclient-new-workdir.py
  70. gclient.bat
  71. gclient.py
  72. gclient_completion.sh
  73. gclient_eval.py
  74. gclient_paths.py
  75. gclient_scm.py
  76. gclient_utils.py
  77. gerrit_client.py
  78. gerrit_util.py
  79. git-cache
  80. git-cl
  81. git-crrev-parse
  82. git-drover
  83. git-find-releases
  84. git-footers
  85. git-freeze
  86. git-gs
  87. git-hyper-blame
  88. git-map
  89. git-map-branches
  90. git-mark-merge-base
  91. git-migrate-default-branch
  92. git-nav-downstream
  93. git-nav-upstream
  94. git-new-branch
  95. git-number
  96. git-rebase-update
  97. git-rename-branch
  98. git-reparent-branch
  99. git-retry
  100. git-runhooks
  101. git-squash-branch
  102. git-thaw
  103. git-upstream-diff
  104. git_cache.py
  105. git_cl.py
  106. git_cl_completion.sh
  107. git_common.py
  108. git_dates.py
  109. git_drover.py
  110. git_find_releases.py
  111. git_footers.py
  112. git_freezer.py
  113. git_hyper_blame.py
  114. git_map.py
  115. git_map_branches.py
  116. git_mark_merge_base.py
  117. git_migrate_default_branch.py
  118. git_nav_downstream.py
  119. git_new_branch.py
  120. git_number.py
  121. git_rebase_update.py
  122. git_rename_branch.py
  123. git_reparent_branch.py
  124. git_retry.py
  125. git_squash_branch.py
  126. git_upstream_diff.py
  127. gn
  128. gn.bat
  129. gn.py
  130. goma_auth
  131. goma_auth.bat
  132. goma_ctl
  133. goma_ctl.bat
  134. GOMA_OWNERS
  135. gsutil.py
  136. gsutil.py.bat
  137. gsutil.vpython
  138. led
  139. led.bat
  140. LICENSE
  141. lockfile.py
  142. luci-auth
  143. luci-auth.bat
  144. LUCI_OWNERS
  145. lucicfg
  146. lucicfg.bat
  147. mac_toolchain
  148. metrics.py
  149. metrics.README.md
  150. metrics_utils.py
  151. my_activity.py
  152. ninja
  153. ninja-linux32
  154. ninja-linux64
  155. ninja-mac
  156. ninja.exe
  157. ninjalog.README.md
  158. ninjalog_uploader.py
  159. ninjalog_uploader_wrapper.py
  160. OWNERS
  161. owners.py
  162. owners_client.py
  163. owners_finder.py
  164. post_build_ninja_summary.py
  165. PRESUBMIT.py
  166. presubmit_canned_checks.py
  167. presubmit_support.py
  168. profile.xml
  169. prpc
  170. prpc.bat
  171. pylint
  172. pylint-1.5
  173. pylint-1.6
  174. pylint-1.7
  175. pylint-1.8
  176. pylint-1.9
  177. pylint-2.6
  178. pylint.bat
  179. pylint_main.py
  180. pylintrc
  181. python_runner.sh
  182. rdb
  183. rdb.bat
  184. rdb_wrapper.py
  185. README.gclient.md
  186. README.git-cl.md
  187. README.md
  188. repo
  189. roll-dep
  190. roll-dep.bat
  191. roll_dep.py
  192. scm.py
  193. setup_color.py
  194. split_cl.py
  195. subcommand.py
  196. subprocess2.py
  197. update_depot_tools
  198. update_depot_tools.bat
  199. update_depot_tools_toggle.py
  200. upload_metrics.py
  201. upload_to_google_storage.py
  202. vpython
  203. vpython.bat
  204. vpython3
  205. vpython3.bat
  206. WATCHLISTS
  207. watchlists.py
  208. weekly
  209. win32imports.py
  210. wtf
  211. yapf
  212. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.