commit | 0e4e5ae5944afdca30a6228cb2b56c8298e07a70 | [log] [tgz] |
---|---|---|
author | Edward Lesmes <ehmaldonado@google.com> | Fri Jan 08 18:28:46 2021 +0000 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 08 18:28:46 2021 +0000 |
tree | 17500d962d20c07b3f4465341a624e943dbf8eb1 | |
parent | 60b433cf0b29e12218abbdf36a8d166fc59e7209 [diff] |
Reland "[owners] Refactor OwnersClient." Reland of [1]. Original CL contained some changes to --[tb]r-owners which are not included in this CL because those changes were reverted on [2]. - Remove GetChangeApprovalStatus and GetFilesApprovalStatus. - Make host, project and branch part of GerritClient. - Rename ListOwnersForFile to ListOwners. [1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268 [2] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2611219 Change-Id: Ife2051b8be0460d1c6bc4fbe4e3b0a571d12dafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2616130 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.