cos-gpu-installer-v2: Change logging behavior on expected driver installation failure
COS GPU installer produces error logs like: "Loading of unsigned module
is rejected". It seems that these errors are red herrings and not
indicate installer or driver malfunction.
BUG=b/178506105
TEST=go build && go test; # installer package
Change-Id: I9740ef40d13b8585c5a634c7ce181d137ca909b8
Reviewed-on: https://cos-review.googlesource.com/c/cos/tools/+/14111
Reviewed-by: Ke Wu <mikewu@google.com>
Tested-by: Arnav Kansal <rnv@google.com>
diff --git a/src/pkg/utils/utils.go b/src/pkg/utils/utils.go
index d93efa0..fbc831c 100644
--- a/src/pkg/utils/utils.go
+++ b/src/pkg/utils/utils.go
@@ -268,8 +268,13 @@
// RunCommandAndLogOutput runs the given command and logs the stdout and stderr in parallel.
func RunCommandAndLogOutput(cmd *exec.Cmd, expectError bool) error {
+ errLogger := log.Error
+ if expectError {
+ errLogger = log.V(1).Info
+ }
+
cmd.Stdout = &loggingWriter{logger: log.Info}
- cmd.Stderr = &loggingWriter{logger: log.Error}
+ cmd.Stderr = &loggingWriter{logger: errLogger}
err := cmd.Run()
if _, ok := err.(*exec.ExitError); ok && expectError {
