changelog-web: Direct Gerrit link
This CL changes web Gerrit links to direct to the Gerrit CL instead of directing to the query page. It also enables autocomplete for forms.
BUG=b/160901711
TEST=run local
Change-Id: Ib71add936f3c53278d8fe74cde39bcde7d10e797
diff --git a/src/cmd/changelog-webapp/controllers/pageHandlers.go b/src/cmd/changelog-webapp/controllers/pageHandlers.go
index cac116f..20bf4e5 100644
--- a/src/cmd/changelog-webapp/controllers/pageHandlers.go
+++ b/src/cmd/changelog-webapp/controllers/pageHandlers.go
@@ -400,9 +400,9 @@
}
var gerritLink string
if didFallback {
- gerritLink = fallbackGerrit + "/q/" + buildData.CLNum
+ gerritLink = fallbackGerrit + "/c/" + buildData.CLNum
} else {
- gerritLink = gerrit + "/q/" + buildData.CLNum
+ gerritLink = gerrit + "/c/" + buildData.CLNum
}
page := &findBuildPage{
CL: cl,
diff --git a/src/cmd/changelog-webapp/static/templates/changelog.html b/src/cmd/changelog-webapp/static/templates/changelog.html
index d5c103f..aeca7c9 100644
--- a/src/cmd/changelog-webapp/static/templates/changelog.html
+++ b/src/cmd/changelog-webapp/static/templates/changelog.html
@@ -32,15 +32,15 @@
<div class="text">
<label>From </label>
{{if (ne .Source "")}}
- <input type="text" class="source" name="source" placeholder="Image Name or Build Number" value={{.Source}} autocomplete="off" required>
+ <input type="text" class="source" name="source" placeholder="Image Name or Build Number" value={{.Source}} required>
{{else}}
- <input type="text" class="source" name="source" placeholder="Image Name or Build Number" autocomplete="off" required>
+ <input type="text" class="source" name="source" placeholder="Image Name or Build Number" required>
{{end}}
<label> to </label>
{{if (ne .Target "")}}
- <input type="text" class="target" name="target" placeholder="Image Name or Build Number" value={{.Target}} autocomplete="off" required>
+ <input type="text" class="target" name="target" placeholder="Image Name or Build Number" value={{.Target}} required>
{{else}}
- <input type="text" class="target" name="target" placeholder="Image Name or Build Number" autocomplete="off" required>
+ <input type="text" class="target" name="target" placeholder="Image Name or Build Number" required>
{{end}}
<input type="hidden" name="n" value={{.QuerySize}}>
<input class="submit" type="submit" value="Submit"><br>
diff --git a/src/cmd/changelog-webapp/static/templates/findBuild.html b/src/cmd/changelog-webapp/static/templates/findBuild.html
index 979f7fa..9b66fec 100644
--- a/src/cmd/changelog-webapp/static/templates/findBuild.html
+++ b/src/cmd/changelog-webapp/static/templates/findBuild.html
@@ -37,9 +37,9 @@
<form class="changelog-form" action="/findbuild">
<div class="text">
{{if (ne .CL "")}}
- <input type="text" class="cl-input" name="cl" placeholder="CL-Number or Commit-SHA" value={{.CL}} autocomplete="off" required>
+ <input type="text" class="cl-input" name="cl" placeholder="CL-Number or Commit-SHA" value={{.CL}} required>
{{else}}
- <input type="text" class="cl-input" name="cl" placeholder="CL-Number or Commit-SHA" autocomplete="off" required>
+ <input type="text" class="cl-input" name="cl" placeholder="CL-Number or Commit-SHA" required>
{{end}}
<input class="submit" type="submit" value="Submit"><br>
</div>
diff --git a/src/pkg/utils/changelogerror.go b/src/pkg/utils/changelogerror.go
index 64feab4..59c4d31 100644
--- a/src/pkg/utils/changelogerror.go
+++ b/src/pkg/utils/changelogerror.go
@@ -130,7 +130,7 @@
}
func clLink(clID, instanceURL string) string {
- return fmt.Sprintf("<a href=\"%s/q/%s\" target=\"_blank\">CL %s</a>", instanceURL, clID, clID)
+ return fmt.Sprintf("<a href=\"%s/c/%s\" target=\"_blank\">CL %s</a>", instanceURL, clID, clID)
}
// CLNotFound returns a ChangelogError object for findbuild indicating the provided
