)]}' { "log": [ { "commit": "8558f83888cd36610a071c6d5864de23b9e9d80f", "tree": "debe977c29f2fbfd8fa6327530f6966a2f55f5a6", "parents": [ "f361d52e5882f9e15767cb002c4d55e718c02a75" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Tue Jun 20 15:11:58 2023 -0700" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Fri Jul 21 01:19:56 2023 +0000" }, "message": "LAKITU: make repohooks compatible with older COS branches\n\nBUG\u003db/277779682\nTEST\u003dUpload change on M93\nRELEASE_NOTE\u003dNone\n\nChange-Id: I96c921e471e6d196548e3059e10f4d59e45d6798\nReviewed-on: https://cos-review.googlesource.com/c/cos/repohooks/+/50870\nReviewed-by: He Gao \u003chegao@google.com\u003e\nTested-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\n" }, { "commit": "f361d52e5882f9e15767cb002c4d55e718c02a75", "tree": "d421c034b8d300a5a1a74191ae154626a188f80c", "parents": [ "1e837b40c6c502e5a57be29f586270baccc4231b", "61ecb0c9263c94e6491bdc636113ea39f2e94705" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Thu Jul 20 17:52:25 2023 -0700" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Thu Jul 20 17:52:49 2023 -0700" }, "message": "Merge remote-tracking branch \u0027cos/upstream/main\u0027 into master\n\nUpdate to be compatible with new chromite\n\nBUG\u003db/277779682\nTEST\u003d`repo upload`\nRELEASE_NOTE\u003dNone\n\nChange-Id: I2f808b196c11f36fa1600ef4a957d0cceed95fc4\n" }, { "commit": "1e837b40c6c502e5a57be29f586270baccc4231b", "tree": "da1eeea3ba6d421e016331ed3b5a64ba687ddbb9", "parents": [ "65a09e2c58fc8ba2110491be9d2c6eedef9ac903" ], "author": { "name": "Alan Berryhill", "email": "berryhill@google.com", "time": "Fri Jul 07 23:10:10 2023 +0000" }, "committer": { "name": "Alan Berryhill", "email": "berryhill@google.com", "time": "Mon Jul 10 21:48:32 2023 +0000" }, "message": "exclude metadata.xml from license check\n\nThe metadata.xml files should be excluded from the license checks. It\u0027s\njust metadata about the package, and doesn\u0027t need a license string.\nMoreover, the recommended license strings from the presubmit are\ninvalid XML that cause parsing errors.\n\nBUG\u003dNone\nTEST\u003dpushed a change with metadata in board-overlays, hooks passed\nRELEASE_NOTE\u003dn/a\n\nChange-Id: I230080e3e634594ad0e9b82a3deb524f50f36fd6\nReviewed-on: https://cos-review.googlesource.com/c/cos/repohooks/+/51831\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Vaibhav Rustagi \u003cvaibhavrustagi@google.com\u003e\n" }, { "commit": "61ecb0c9263c94e6491bdc636113ea39f2e94705", "tree": "5f3f5e8f51ef92db2db764c1be0c659e2b22f776", "parents": [ "8a9f363fadb85f237d87a45033cdb491626d5157" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Tue May 09 19:57:26 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 09 20:11:45 2023 +0000" }, "message": "pre-upload: Exclude (DIR_)?METADATA files from _check_for_uprev\n\nWe do not need to uprev ebuilds when the changes are in either\nDIR_METDATA or METADATA.\n\nBUG\u003db:281719335\nTEST\u003drepo upload .\n\nChange-Id: I0e2cd146eff15258bf99fe58111fe3d43fc9c610\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4518327\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Allen Webb \u003callenwebb@google.com\u003e\n" }, { "commit": "8a9f363fadb85f237d87a45033cdb491626d5157", "tree": "ce7594764386a7dbea4c1530e43ce3c6780b19d3", "parents": [ "e7fa5648e49726f68061a6d839d45657436f87dc" ], "author": { "name": "Andrew Lamb", "email": "andrewlamb@chromium.org", "time": "Thu May 04 19:06:32 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 05 16:56:36 2023 +0000" }, "message": "Use `git-cl` instead of `presubmit_support.py`.\n\n- Calling `presubmit_support.py` doesn\u0027t populate the CL\ndescription automatically, so PRESUBMIT.py checks that rely on\nthe description (or tags parsed from the description) will get\nempty description / tags. For example, this check is failing\nb/c tags aren\u0027t read:\nhttp://cs/chromeos_internal/src/config-internal/PRESUBMIT.py;l\u003d76;rcl\u003d840ef2748303572f0fdc9adfd48ff68dc9fe8b4d.\n\nBUG\u003dNone\nTEST\u003dRan `pre-upload.py` in the failing repo.\n\nChange-Id: I2a81cd0ddd72e2436432eeebe5b1b15060be6599\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4505516\nCommit-Queue: Andrew Lamb \u003candrewlamb@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nTested-by: Andrew Lamb \u003candrewlamb@chromium.org\u003e\n" }, { "commit": "e7fa5648e49726f68061a6d839d45657436f87dc", "tree": "38b42fef9de708da5c239b9afbf0fcb31675d885", "parents": [ "7b815f09612e8a9ad0a4d8330b9f6b1f2e728dcf" ], "author": { "name": "Matt Stark", "email": "msta@google.com", "time": "Tue May 02 11:14:27 2023 +1000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 04 17:51:12 2023 +0000" }, "message": "Remove line limit for bzl files.\n\nBUG\u003dNone\nTEST\u003drepo upload on commit with \u003e80 line length in bzl files.\n\nChange-Id: Ib83bb4199efb60d5eaa9a502b99db07c6e93ca7a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4494674\nTested-by: Matt Stark \u003cmsta@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Matt Stark \u003cmsta@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7b815f09612e8a9ad0a4d8330b9f6b1f2e728dcf", "tree": "21f0a74163fb0467b54ca6ea12eb87ae4fae60ef", "parents": [ "42512b2d6b4514f01d6fa3369e841035856d7e12" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Mon May 01 17:53:54 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 02 00:21:35 2023 +0000" }, "message": "pre-upload: Let branch_check operate in an optional mode\n\nCreate a new optional flag to branch_check, and make this mode have\ndifferent behavior:\n\n BRANCH\u003d can either be given or not, but if it is, you can\u0027t write\n BRANCH\u003dnone (including in different casings, like \"None\").\n\nIdeally, I\u0027d like to make this the default tree-wide for all repos\nthat have branch_check (firmware repos), but making it an option will\nenable us to beta-test this behavior on EC only initially. The\ndefault behavior is currently required, but configs can ask for it to\nbe explicitly required using \"--required\".\n\nBUG\u003db:280345831\nTEST\u003dunit tests\n\nChange-Id: I80b98f551f32d344a4ec64d9cd67da7e821bc6dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4497653\nReviewed-by: Jeremy Bettis \u003cjbettis@chromium.org\u003e\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Jeremy Bettis \u003cjbettis@chromium.org\u003e\n" }, { "commit": "42512b2d6b4514f01d6fa3369e841035856d7e12", "tree": "fb1675a38a6d7f49ebd8db5995c565db6e822bb8", "parents": [ "382645766f7090ce98a8ea7f7d24d60bcdab0296" ], "author": { "name": "Alex Klein", "email": "saklein@chromium.org", "time": "Mon Apr 17 16:06:33 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 26 16:12:16 2023 +0000" }, "message": "pre-upload.py: Fix unnecessary-comprehension lint.\n\nBUG\u003dNone\nTEST\u003d./pre-upload_unittest.py\n\nChange-Id: I7cd113b045b96b121ae82e82c74e3aa0cda9e412\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4437589\nTested-by: Alex Klein \u003csaklein@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "382645766f7090ce98a8ea7f7d24d60bcdab0296", "tree": "dcb7937a5a877788f45479890b97a00657cb2c7b", "parents": [ "323cf6b5e186fb8ef5e95c1b9a6928c740941d69" ], "author": { "name": "Juliana Chang", "email": "julianachang@google.com", "time": "Tue Apr 25 14:15:24 2023 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Apr 25 07:25:35 2023 +0000" }, "message": "Don\u0027t check line length for BUILD files\n\nFollow up work for crrev/c/4443397.\n\nBUG\u003db:278807097\nTEST\u003drepo upload\n\nChange-Id: Iff1699b0b5328c6243332d41fbe35a36876acd4c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4473608\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Juliana Chang \u003cjulianachang@chromium.org\u003e\nCommit-Queue: Juliana Chang \u003cjulianachang@chromium.org\u003e\n" }, { "commit": "323cf6b5e186fb8ef5e95c1b9a6928c740941d69", "tree": "0c99196d1a6bfeee255f310f1744490e6af03c28", "parents": [ "e3cb8d4191221e8d370e37035b10bfa4f7fb87bf" ], "author": { "name": "Shuhei Takahashi", "email": "nya@chromium.org", "time": "Wed Apr 19 20:45:59 2023 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 19 18:45:09 2023 +0000" }, "message": "Don\u0027t check line length for BUILD files\n\nThe style guide says \"it should not be enforced in code reviews or\npresubmit scripts\".\n\nBUG\u003db:278807097\nTEST\u003drepo upload\n\nChange-Id: I28ec4ffd397a30d9bb52eceaedab188d3dbbaa5a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4443397\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Shuhei Takahashi \u003cnya@chromium.org\u003e\nAuto-Submit: Shuhei Takahashi \u003cnya@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "e3cb8d4191221e8d370e37035b10bfa4f7fb87bf", "tree": "1cd77c9305970af152d224e05625028b927e25b7", "parents": [ "cc955f2e664e6e0c1746443e41551a0a933ab14c" ], "author": { "name": "Shuhei Takahashi", "email": "nya@chromium.org", "time": "Wed Apr 19 12:19:16 2023 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 19 18:45:07 2023 +0000" }, "message": "Include Bazel-related files in repo upload checks\n\nBUG\u003db:278807097\nTEST\u003drepo upload # copyright header check runs\n\nChange-Id: I5c55d359026e2145b6442be655f9d0d9426ea5ed\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4445576\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Shuhei Takahashi \u003cnya@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Shuhei Takahashi \u003cnya@chromium.org\u003e\n" }, { "commit": "cc955f2e664e6e0c1746443e41551a0a933ab14c", "tree": "3e6ea5db7263fad2a6e0caa9627c66727e1aecd1", "parents": [ "2acb91a18020aa3fa39c11d32619683de3195e35" ], "author": { "name": "Alex Klein", "email": "saklein@chromium.org", "time": "Fri Apr 14 15:01:48 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Apr 18 14:32:39 2023 +0000" }, "message": "Spelling fixes.\n\nBUG\u003dNone\nTEST\u003dCQ\n\nChange-Id: I24db8f45ea6ef66ef60825dc07213979408baf11\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4429571\nTested-by: Alex Klein \u003csaklein@chromium.org\u003e\nReviewed-by: Gilberto Contreras \u003cgcontreras@google.com\u003e\nCommit-Queue: Gilberto Contreras \u003cgcontreras@google.com\u003e\nAuto-Submit: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "2acb91a18020aa3fa39c11d32619683de3195e35", "tree": "c2a5de52f692709824d9e0c120f7e3be1db7a987", "parents": [ "2b17f91601b2779466c6e3ff613aa2c91aed1267" ], "author": { "name": "Alex Klein", "email": "saklein@chromium.org", "time": "Fri Apr 14 15:55:30 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Apr 17 18:40:37 2023 +0000" }, "message": "Skip running unit tests on pre-upload.\n\nThe unittests now have CQ coverage, so defer unittest enforcement\nto that, and follow current best practices with preupload checks;\ndisable the unittests.\n\nBUG\u003db:277923207\nTEST\u003dNone\n\nChange-Id: Ibd9b4eb24d450721a71c706b47c1d6176c385919\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4429573\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\nTested-by: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "2b17f91601b2779466c6e3ff613aa2c91aed1267", "tree": "b0f811c09b4664d72a1eb1d0f0f6b845288ec22c", "parents": [ "123e51db0bb1b54bb8a895f11f527a999229f05c" ], "author": { "name": "Jeremy Bettis", "email": "jbettis@google.com", "time": "Wed Apr 12 10:29:31 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 12 21:04:39 2023 +0000" }, "message": "README: Add better examples\n\nSince the examples are likely to be copy/pasted into various configs,\nadd cros format and pass the --commit flag to cros lint.\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: Ib22383bd877bb201979a4ccba78667ceee4a444d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4418891\nAuto-Submit: Jeremy Bettis \u003cjbettis@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Jeremy Bettis \u003cjbettis@chromium.org\u003e\n" }, { "commit": "123e51db0bb1b54bb8a895f11f527a999229f05c", "tree": "cdda3d488062d33193fc54a0f2254076dac8529e", "parents": [ "beb339c9376dbefcea60797be16b4ed0809177cd" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 29 00:32:02 2023 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 30 03:22:46 2023 +0000" }, "message": "PRESUBMIT: lint commits, not files\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I3d5fea051252a0772a58dce212f5af1cd4dc2a12\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4378295\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "beb339c9376dbefcea60797be16b4ed0809177cd", "tree": "a88cb587bd7ca25729b480e541f70d3047d3064f", "parents": [ "013806ff1b3321e9f335474e2d03d95da0de85db" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 10:05:40 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 30 03:22:33 2023 +0000" }, "message": "git-clang-format: sync to the latest version\n\nPull the latest version from upstream -- the one we\u0027ve been using has\nbeen frozen for a couple of years now.\n\nhttps://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format\nff85a0b3f71d2829f2aa5b1adb4c8ff800d5d09e\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I8ea21d3b11278819d6347f37c1299235b85b2e85\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4317106\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "013806ff1b3321e9f335474e2d03d95da0de85db", "tree": "5c6c16de0e8483f41ce2b2925750353b371f98e0", "parents": [ "9485b7116dc0ee93a5eb9ee7437fc62f69c16116" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 29 00:30:56 2023 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 29 21:28:59 2023 +0000" }, "message": "pre-upload_unittest: update after chromite Path changes\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I28a6d0688d4f214e93458b98649e7cb8a36f7ff9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4378294\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\n" }, { "commit": "9485b7116dc0ee93a5eb9ee7437fc62f69c16116", "tree": "a4b545fa35fffca1d8e95e263ce2297b1851368c", "parents": [ "a6a621fb498f53511e77a0adbcf28b5c4d01a0ba" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Wed Mar 22 14:57:36 2023 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 24 18:15:16 2023 +0000" }, "message": "pre-upload: git_cl_presubmit: Don\u0027t search PATH\n\nThis script may not be found on PATH (or, in some cases it may not be a\n(v)python script); locating it via chromite is more direct and less\nerror-prone.\n\nBUG\u003db:270994985\nTEST\u003dpre-upload.py in src/project/... repos\n\nChange-Id: I9e0152f07c3d020581943d915bb919f6f18f921f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4363003\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "a6a621fb498f53511e77a0adbcf28b5c4d01a0ba", "tree": "811ad6459050a2abc4c2812e7aae94de54b93985", "parents": [ "d4973c8055902adf19ce887482ac6eae9bdb7f3a" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Mon Mar 13 12:21:42 2023 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 13 18:37:20 2023 +0000" }, "message": "README: Drop pre-upload_unittest from example config\n\nLet\u0027s not be hypocrites ... still have to remove from the\nPRESUBMIT.cfg in this repo, however.\n\nBUG\u003dnone\nTEST\u003dview in gitiles\n\nChange-Id: I99c8ecf0febe70ce1ca4acd80c10c66bfe94617e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4334183\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "d4973c8055902adf19ce887482ac6eae9bdb7f3a", "tree": "f28868932b5ae2f7720f8c6d4ba7a8637f4527a8", "parents": [ "df9d6e3e19bb3893af2b4c1f9d55c59788e62f30" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Fri Mar 10 12:29:18 2023 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 13 16:50:28 2023 +0000" }, "message": "README: Document guidelines for pre-upload hooks\n\nI roughly documented what makes a pre-upload hook suck in my\npresentation at go/cros-repo-hooks.\n\nLet\u0027s formalize this into the docs.\n\nBUG\u003dnone\nTEST\u003dview in gitiles\n\nChange-Id: I249dc2139a1ba991945d6508e83b25c7df6b09e6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4330022\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "df9d6e3e19bb3893af2b4c1f9d55c59788e62f30", "tree": "9b2fc5cf48e80ea97e8466bb0bfa2bf0950892d4", "parents": [ "5bfdffd5ffffce0c113e56f98da4d7cc769ebbb0" ], "author": { "name": "Sergey Frolov", "email": "sfrolov@google.com", "time": "Wed Mar 08 19:20:39 2023 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 09 02:55:09 2023 +0000" }, "message": "repohooks: only require sudo if hook\u0027s options set\n\nBUG\u003db:272368241\nTEST\u003dmanual\n\nChange-Id: I8c9d1370997237b1632376d4a80795f2dbe60d65\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4321681\nCommit-Queue: Sergey Frolov \u003csfrolov@google.com\u003e\nTested-by: Sergey Frolov \u003csfrolov@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "5bfdffd5ffffce0c113e56f98da4d7cc769ebbb0", "tree": "41dc57b4ea03f8f94913b020324fc3192224008c", "parents": [ "d419c74c388d391b6ae8dec436040c0427a594df" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 01:44:52 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 08 15:17:20 2023 +0000" }, "message": "pyproject.toml: drop redundant file\n\nThis is no longer used with the switch to cros format.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I0cdb5b601c29bd05baa9f1e9f4ee3306aefe9280\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4296789\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Gilberto Contreras \u003cgcontreras@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Gilberto Contreras \u003cgcontreras@google.com\u003e\n" }, { "commit": "d419c74c388d391b6ae8dec436040c0427a594df", "tree": "8218c5c73b13dd70d89b30e1e174223ad3d4fa95", "parents": [ "8b490d2573e420d5202f4359e6ac5979ddefb96f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Mar 07 17:57:38 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 07 23:07:13 2023 +0000" }, "message": "clang-format: fix basic logic error\n\nSome rebasing of changes resulted in bad merge. Add a small unittest\nto prevent at least this level of breakage from happening again.\n\nBUG\u003dNone\nTEST\u003d`repo upload` works\n\nChange-Id: I7827f1b6871e78392425d2e1432e1910e08d18f0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4316977\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Tim Van Patten \u003ctimvp@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jim Pollock \u003cjmpollock@chromium.org\u003e\nCommit-Queue: Jim Pollock \u003cjmpollock@chromium.org\u003e\n" }, { "commit": "8b490d2573e420d5202f4359e6ac5979ddefb96f", "tree": "a99dc13c463d8cfcaf91357a019035054d662884", "parents": [ "47c4ff932d78fa027e0dcb9442eda73efef1b44a" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Mar 07 16:17:21 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 07 21:28:57 2023 +0000" }, "message": "clang-format: update chromite path after move\n\nBUG\u003dNone\nTEST\u003d`./third_party/clang-format.py --help` works\n\nChange-Id: I6f79b982807535ce697d4ddec35e0b117f1fdc85\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4316972\nCommit-Queue: Tim Van Patten \u003ctimvp@google.com\u003e\nReviewed-by: Tim Van Patten \u003ctimvp@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "47c4ff932d78fa027e0dcb9442eda73efef1b44a", "tree": "d6c10735ccc97e43d11b1c986403b0d31102ac07", "parents": [ "72660e2f82350195aaad25cf61edd407e359a1c6" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 10:02:46 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 07 21:19:28 2023 +0000" }, "message": "clang-format: vendor in the git-clang-format tool\n\nThis is a pretty small standalone tool, so rather than force everyone\nto sync a dedicated git project for it, vendor it into the tree. It\nis copied directly from the current file:\nsrc/chromium/src/buildtools/clang_format/script/git-clang-format\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I012950a0fa5dd131f213c3354d0ba44b6335a327\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4317105\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "72660e2f82350195aaad25cf61edd407e359a1c6", "tree": "7ba498e364d3432a8e3d816b6dec3682aaa6661e", "parents": [ "dc558ceb53dd23f255acef510442f3a7b18860f9" ], "author": { "name": "Sergey Frolov", "email": "sfrolov@google.com", "time": "Thu Mar 02 16:14:23 2023 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 07 21:14:39 2023 +0000" }, "message": "repo-hooks: ask for sudo in advance\n\nBUG\u003db:268126944\nTEST\u003dmanual upload in rust repos\n\nChange-Id: Ib9b048d7490af3e924d599ea9f4438aa854be6c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4305035\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Sergey Frolov \u003csfrolov@google.com\u003e\nTested-by: Sergey Frolov \u003csfrolov@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Sergey Frolov \u003csfrolov@google.com\u003e\n" }, { "commit": "dc558ceb53dd23f255acef510442f3a7b18860f9", "tree": "f7c786aa584f5719e8031f3c4b27c7416460dfff", "parents": [ "518cde9f9c0578d5eba7625a717fcb890bf5e3e0" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Mar 07 13:47:13 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 07 19:43:09 2023 +0000" }, "message": "PRESUBMIT: update format checks for third_party/*\n\nBUG\u003dNone\nTEST\u003d`repo upload` doesn\u0027t complain about this subdir\n\nChange-Id: I26f3eabb6fa73e3720d81f088e199a6cc3925fcd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4317104\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Sergey Frolov \u003csfrolov@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Sergey Frolov \u003csfrolov@google.com\u003e\n" }, { "commit": "518cde9f9c0578d5eba7625a717fcb890bf5e3e0", "tree": "7f21fbb8a0275e940abc5aadeafcf23b7a8dd2bb", "parents": [ "d7044c66fc55642d5fee14454c03e743feacfb01" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 10:00:11 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Mar 07 18:23:30 2023 +0000" }, "message": "third_party: move vendored tools here\n\nThis follows Google guidelines more by putting 3rd party code into a\ndedicated \"third_party\" directory separate from our 1pp code, and it\nmakes the overall directory a little more tidy.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I87e6ff25f8852a7ec23e04ba746bac2a1f9be5c2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4300532\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "d7044c66fc55642d5fee14454c03e743feacfb01", "tree": "ef5652a61a2a81550cf5c9592c072df86f46f210", "parents": [ "02fcf7efc293445d09effce2445a86392b1051e7" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 09:54:41 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 06 04:08:34 2023 +0000" }, "message": "pre-upload: switch to REPOHOOKS_DIR\n\nThe _get_hooks_dir hack was to workaround repo not providing __file__\nwhen loading the hook modules. I fixed that years ago in repo, so we\ncan assume it\u0027s always defined now and use the existing constant.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I618bbe9e0459ce3eebe75cdf2eca62f5abbf2f0f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4300531\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "02fcf7efc293445d09effce2445a86392b1051e7", "tree": "126e1352884fbd6af06636bb9bc66d438ca538d4", "parents": [ "47d01d5b76fa7d09afb6d4d5f558b1c2b615d24b" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 14:28:55 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 02 00:02:21 2023 +0000" }, "message": "pre-upload: tweak formatting after black update\n\nBUG\u003dNone\nTEST\u003d`cros format` is clean\n\nChange-Id: I916a758765176071bddc11a1572b41fda289e1fe\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4300533\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\n" }, { "commit": "47d01d5b76fa7d09afb6d4d5f558b1c2b615d24b", "tree": "ce99388e3f996044140daf95170bd6b328a4f0d4", "parents": [ "2806a7841c7104edc92cc12ac2ce8ab351b43194" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Mar 01 09:51:44 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Mar 01 19:23:46 2023 +0000" }, "message": "pre-upload: cache hooks dir lookup\n\nThis speeds up unittests significantly by only running this logic once.\n\nBUG\u003dNone\nTEST\u003dunittests pass\n\nChange-Id: I71c5f8ec6d0b27c27cd7023225250c5d49683a14\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4298278\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "2806a7841c7104edc92cc12ac2ce8ab351b43194", "tree": "f8e84db0f87d0e2c03e7d531173eea771d69cea2", "parents": [ "e2f066a618dfb700228df99efa3423b7c5778d60" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Feb 27 16:12:37 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 27 22:28:53 2023 +0000" }, "message": "README: fix blocked terms anchor\n\ngitiles doesn\u0027t support `_`, so these anchors don\u0027t work.\n\nBUG\u003dNone\nTEST\u003dread file online\n\nChange-Id: I9f3ac13b26e5a9a9aff1add239a33c907dc91f54\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4294862\nCommit-Queue: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "e2f066a618dfb700228df99efa3423b7c5778d60", "tree": "6636fde81dd5dad28e56942cc4e59f1e05559757", "parents": [ "80eecf0ecf9418cd5bdd066df0c45d50c0b5814a" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Feb 27 15:09:08 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 27 20:43:23 2023 +0000" }, "message": "pre-upload: add explicit open encoding\n\nBUG\u003db:187789896\nTEST\u003d`cros lint` is clean\n\nChange-Id: Ib2d874c84ed28f7a2f9f88d923cda2e2eaf196ab\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4294857\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "80eecf0ecf9418cd5bdd066df0c45d50c0b5814a", "tree": "471b7ca1a756fc3a2d0443e9d52fcfc204d3180c", "parents": [ "1f48d3b85ec9795058aa2bc390d2db07097c1830" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Feb 27 15:03:44 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 27 20:26:26 2023 +0000" }, "message": "pre-upload: expand PRESUBMIT_COMMIT inline too\n\nSupport commands appending ${PRESUBMIT_COMMIT} to other options like\n-foo\u003d${PRESUBMIT_COMMIT}.\n\nBUG\u003db:270987430\nTEST\u003d`repo upload` in tast-tests works\n\nChange-Id: I2afacc10cb0bc3e9d7b71336f3189fa5c50aaa0d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4294855\nReviewed-by: Sergey Frolov \u003csfrolov@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Sergey Frolov \u003csfrolov@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "1f48d3b85ec9795058aa2bc390d2db07097c1830", "tree": "f116008cca09c2052d596657eccbc0b30237d472", "parents": [ "3334760547ba9762364acbf07f7d1218e05141b1" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Feb 09 14:05:41 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Feb 25 13:17:44 2023 +0000" }, "message": "Reland \"pre-upload: expand placeholders ourselves\"\n\nThis is a reland of commit 58a2b4d6f026135a7afe77ca621b11ae0752f4fb\n\nThe existing PRESUBMIT.cfg hooks that were inline shell scripts have\nbeen converted to simple commands, and this code no longer tries to\nrejoin the split command line into a shell command.\n\nOriginal change\u0027s description:\n\u003e pre-upload: expand placeholders ourselves\n\u003e\n\u003e This allows correct processing of filenames with spaces.\n\u003e\n\u003e BUG\u003dNone\n\u003e TEST\u003d`repo upload` works\n\u003e\n\u003e Change-Id: I173056029c1410ca205266ea0397158823f9a566\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4234473\n\u003e Tested-by: Li-Yu Yu \u003caaronyu@google.com\u003e\n\u003e Reviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\n\u003e Commit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n\nBUG\u003dNone\nTEST\u003d`repo upload` works\n\nChange-Id: I1112c68633e8bf4c45c8e8769ab3073f552d7aa0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4250897\nReviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3334760547ba9762364acbf07f7d1218e05141b1", "tree": "9164c49f672d61a6648ae2b1a8437f1b798c7c14", "parents": [ "5fcfeeaf917778ef2c64d0ce4dacde3bb41ddec4" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Feb 22 20:43:23 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Feb 23 06:01:48 2023 +0000" }, "message": "clang-format: switch to chromite wrapper\n\nWe have logic in chromite now to fetch the binary on the fly,\nso switch over to that.\n\nBUG\u003db:244479571\nTEST\u003d`repo upload` works\n\nChange-Id: I71b0256d18cd8b96e8ba0c2c5b2004f49f705454\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4284859\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\n" }, { "commit": "5fcfeeaf917778ef2c64d0ce4dacde3bb41ddec4", "tree": "d0290703f0f832fa5ad0f244ac7976c9b151ec4f", "parents": [ "319794dd80c9e724e7f22c73307dd5e2cd785127" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Feb 22 10:55:45 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 22 16:24:49 2023 +0000" }, "message": "PRESUBMIT: format commits, not files\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I53789a7b8e15fe292e845c4ef842c8890a40b600\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4281538\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\nCommit-Queue: Cindy Lin \u003cxcl@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "319794dd80c9e724e7f22c73307dd5e2cd785127", "tree": "e4f4659b633cb3c46f95ad8e7b81e58352a6a218", "parents": [ "d97db12f2f35376e19e9f0c2c91ba8c70e2a94c1" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Feb 14 23:29:36 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 15 17:36:30 2023 +0000" }, "message": "pre-upload: start flagging EAPI\u003d5 as old\n\nGentoo is dropping EAPI\u003d5 support, so we want people to update to EAPI\u003d7,\nso start flagging EAPI\u003d5 is old to try and get them to update.\n\nBUG\u003db:187789240\nTEST\u003dCQ passes\n\nChange-Id: I1001ca715dcb09f40d44e49a894e7106a25bf3f5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4253086\nCommit-Queue: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\n" }, { "commit": "d97db12f2f35376e19e9f0c2c91ba8c70e2a94c1", "tree": "86988ca2e7f13d5e1a43a2a15747e8f414fbfdfd", "parents": [ "cab7645f5e7417bad1cf02c1dfcaf4c8e1abb951" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Feb 10 02:59:34 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 15 04:41:35 2023 +0000" }, "message": "git_cl_presubmit: automatically run PRESUBMIT.py\n\nIf a repo has PRESUBMIT.py, then chances are good it wants to run\ngit-cl presubmit checks, so do so automatically.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I581cc87165186530f1e9e6222cc1d897ad46ea24\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4238377\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "cab7645f5e7417bad1cf02c1dfcaf4c8e1abb951", "tree": "5d4599ba8fd76d9a8b4bf9552b4d686f5be759c2", "parents": [ "88467a6a940d863ec9b89ad04f91f158292b73d8" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Feb 13 00:31:38 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Feb 14 17:18:39 2023 +0000" }, "message": "json_check: drop unused \u0026 redundant check\n\nThis isn\u0027t used in repos, and was rarely used, and is covered by the\n`cros lint` tool which is fairly widespread. Delete it.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I7807eed5d127a58a1321a4df1c486e62abf54316\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4243061\nReviewed-by: Ram Chandrasekar \u003crchandrasekar@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "88467a6a940d863ec9b89ad04f91f158292b73d8", "tree": "52a2d3c2dc23137b4fcfae7a40e9bc909d1d4be3", "parents": [ "825cbeef1bd4f8e7626240753e599d973c5a21e8" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Feb 10 02:59:34 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 10 20:34:26 2023 +0000" }, "message": "git_cl_presubmit: add stub config\n\nThis will let us disable it in existing repos before turning on.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I1ea40b6ef6d35716b3bedb1cb6c3ee9f9bde6366\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4241622\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "825cbeef1bd4f8e7626240753e599d973c5a21e8", "tree": "8474ee0fe54ef9159ed5dc99934fdc1250ce87c1", "parents": [ "58a2b4d6f026135a7afe77ca621b11ae0752f4fb" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Thu Feb 09 23:29:53 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Feb 09 23:39:17 2023 +0000" }, "message": "Revert \"pre-upload: expand placeholders ourselves\"\n\nThis reverts commit 58a2b4d6f026135a7afe77ca621b11ae0752f4fb.\n\nReason for revert: blocks all platform2 b/268541153\n\nOriginal change\u0027s description:\n\u003e pre-upload: expand placeholders ourselves\n\u003e\n\u003e This allows correct processing of filenames with spaces.\n\u003e\n\u003e BUG\u003dNone\n\u003e TEST\u003d`repo upload` works\n\u003e\n\u003e Change-Id: I173056029c1410ca205266ea0397158823f9a566\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4234473\n\u003e Tested-by: Li-Yu Yu \u003caaronyu@google.com\u003e\n\u003e Reviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\n\u003e Commit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n\nBug: b:268541153\nChange-Id: I885e1f15e4db96652ddb910a7de2b3e1380c7445\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4234111\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Brian Norris \u003cbriannorris@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nAuto-Submit: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "58a2b4d6f026135a7afe77ca621b11ae0752f4fb", "tree": "697ea46d6b562030552340bcb69c82f2a1196c52", "parents": [ "c562f0d2efd77dc88b5e49ec80dfca4820adea1c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Feb 09 14:05:41 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Feb 09 19:26:36 2023 +0000" }, "message": "pre-upload: expand placeholders ourselves\n\nThis allows correct processing of filenames with spaces.\n\nBUG\u003dNone\nTEST\u003d`repo upload` works\n\nChange-Id: I173056029c1410ca205266ea0397158823f9a566\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4234473\nTested-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nReviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "c562f0d2efd77dc88b5e49ec80dfca4820adea1c", "tree": "8474ee0fe54ef9159ed5dc99934fdc1250ce87c1", "parents": [ "732f74236d4deb94cc1bda4d87fdd403f5677c35" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Feb 08 00:18:09 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 08 06:19:34 2023 +0000" }, "message": "clang-format: switch to vpython3\n\nThe old vpython name is being removed.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I277d11ed76ee160973fbc99b1d15997ca697b61b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4230712\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "732f74236d4deb94cc1bda4d87fdd403f5677c35", "tree": "0f4055c3fcff2e2c942aa10e49765eb4cfa29807", "parents": [ "197da1b66b64516194071b7cf45b72305b052e86" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sun Jan 22 23:15:53 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 26 05:28:27 2023 +0000" }, "message": "pre-upload: switch black (Python) format checks to chromite\n\nThe underlying tools are the same, so there shouldn\u0027t be any changes,\nbut this helps unify the logic a bit so improvements to `cros format`\nautomatically improve pre-upload.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: Id45222de7c711bc6d99b297a9d53107f16d69c3c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4189457\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Sergey Frolov \u003csfrolov@google.com\u003e\n" }, { "commit": "197da1b66b64516194071b7cf45b72305b052e86", "tree": "1ffc1c2bc1ed58117b094d1355a33d97944fe83b", "parents": [ "c734dbad9f7cfdd458aa18b205a3e2dc621054bd" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sun Jan 22 21:05:04 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jan 23 20:07:50 2023 +0000" }, "message": "pre-upload: switch Go \u0026 Rust format checks to chromite\n\nThe underlying tools are the same, so there shouldn\u0027t be any changes,\nbut this helps unify the logic a bit so improvements to `cros format`\nautomatically improve pre-upload.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I257089b7e6763fef2f0bd22c2ecdfa61f978c649\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4186594\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Lizzy Presland \u003czland@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "c734dbad9f7cfdd458aa18b205a3e2dc621054bd", "tree": "dacd710d4d61b27c396678173fc83ae4d4b71c6c", "parents": [ "913f6489b58a3170016c94c5ef9e6b759aa6cbd4" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Jan 21 19:02:53 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Jan 22 04:03:40 2023 +0000" }, "message": "README: make sure all hooks are documented\n\nAdd a unittest to require all hooks are documented, and backfill all\nthe missing ones.\n\nBUG\u003db:266165002\nTEST\u003d`./pre-upload_unittest.py` passes\n\nChange-Id: I43902847dea335a270ac641db340d5d7861bd949\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4186049\nReviewed-by: Guenter Roeck \u003cgroeck@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Guenter Roeck \u003cgroeck@chromium.org\u003e\n" }, { "commit": "913f6489b58a3170016c94c5ef9e6b759aa6cbd4", "tree": "d665380de27f376b4d820bf940ddd248df00ad9f", "parents": [ "2f50a1f76b22dd5850a0f3f1833f40f45b290df1" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Jan 18 00:04:54 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 19 22:43:00 2023 +0000" }, "message": "pre-upload: change PRESUBMIT_FILES to relative paths\n\nThis variables has always used absolute paths, but the documentation\nsays it\u0027s relative, and people seem to expect it\u0027s relative. Since\nwe run the hooks in the top-level of the respective project, using\nrelative paths should be fine, so let\u0027s switch the format.\n\nBUG\u003db:265735970\nTEST\u003dCQ passes\n\nChange-Id: Ie5457816328333726dd115674f5d798ecc6be63b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4175239\nReviewed-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "65a09e2c58fc8ba2110491be9d2c6eedef9ac903", "tree": "dbaec3c3c5b7046e6349d6389c4a8dd384069882", "parents": [ "66253597c629ee0a47790a5f68288a30fd62bb5c" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Fri Dec 02 12:20:51 2022 -0800" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Tue Jan 17 23:05:56 2023 +0000" }, "message": "Use new API for cmd output\n\nThe new API has been available for a while, and the old API is removed in\nthe new chromite. This change should work on all milestones.\n\nBUG\u003db/257271340\nTEST\u003d`repo upload`\nRELEASE_NOTE\u003dNone\n\nChange-Id: I4eb60542b18fa8de8e096f8a71a09743365fa1bf\nReviewed-on: https://cos-review.googlesource.com/c/cos/repohooks/+/39513\nTested-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nReviewed-by: He Gao \u003chegao@google.com\u003e\nReviewed-by: Dexter Rivera \u003criverade@google.com\u003e\n" }, { "commit": "2f50a1f76b22dd5850a0f3f1833f40f45b290df1", "tree": "4b476c883a6b6bd73a86dafed8f950b0c30bdea2", "parents": [ "08ecba8fcfde7369e2de6cdf1c1a22c02a54f1ef" ], "author": { "name": "Peter Marheine", "email": "pmarheine@chromium.org", "time": "Mon Nov 14 17:00:19 2022 +1100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jan 10 03:01:02 2023 +0000" }, "message": "pre-upload: run hooks in parallel\n\nThis can significantly reduce the wall time consumed by pre-upload\nhooks, with a measured 2x improvement when running hooks for this change\nalone.\n\n $ time ./pre-upload.py -j1\n 21.88s user 5.25s system 109% cpu 24.877 total\n $ time ./pre-upload.py -j48\n 21.91s user 5.12s system 214% cpu 12.604 total\n\nCommits are still processed serially because it is assumed that a given\nhook might maintain mutable state that would be visible to other hooks\nrunning for different commits, but that they are unlikely to have\nconflicting state among hooks running for a given commit. Any hooks that\ncurrently have parallelism problems will need to be fixed.\n\nBUG\u003dnone\nTEST\u003dpre-upload_unittest.py\n\nChange-Id: I10b86cd6665cc3fba7666abdaacb93d3c9653a02\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4022753\nCommit-Queue: Peter Marheine \u003cpmarheine@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\n" }, { "commit": "08ecba8fcfde7369e2de6cdf1c1a22c02a54f1ef", "tree": "d58a5356997e655ca4ee92548cf149ac9916e068", "parents": [ "1587fe5fe867048b182df77af46848909a134d44" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Aug 05 14:31:49 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Dec 22 20:20:17 2022 +0000" }, "message": "Revert \"repohooks: Disable enter_chroot when outside a Chromium OS tree\"\n\nThis reverts commit ce8db5c1901d5cf090c780319214731a445596c1.\n\nReason for revert: Breaks unittests.\n\nOriginal change\u0027s description:\n\u003e repohooks: Disable enter_chroot when outside a Chromium OS tree\n\u003e\n\u003e Right now, running `repo upload -c .` in Ti50\u0027s outside-chroot\n\u003e workflow results in rustfmt always outputting the following, making\n\u003e every format check fail:\n\u003e\n\u003e ```\n\u003e 13:43:32.623: ERROR: No SDK version was found. Are you in a Chromium\n\u003e source tree instead of Chromium OS?\n\u003e\n\u003e Please change to a directory inside your Chromium OS source tree\n\u003e and retry. If you need to setup a Chromium OS source tree, see\n\u003e https://dev.chromium.org/chromium-os/developer-guide\n\u003e ```\n\u003e\n\u003e This changes the logic to avoid trying to enter the chroot if it is not\n\u003e a proper ChromiumOS chroot, by checking for a well-known version file.\n\u003e\n\u003e BUG\u003dNone\n\u003e TEST\u003drepo upload -c . now works as expected inside and outside chroot\n\u003e\n\u003e Change-Id: I2baa246d55c2d0e69490802340782211557419e4\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3759265\n\u003e Reviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\n\u003e Reviewed-by: Allen Webb \u003callenwebb@google.com\u003e\n\u003e Commit-Queue: Allen Webb \u003callenwebb@google.com\u003e\n\u003e Auto-Submit: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n\u003e Tested-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n\nChange-Id: I56d20620e270f37682414348ef0b3284058b5e55\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3813692\nReviewed-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "1587fe5fe867048b182df77af46848909a134d44", "tree": "e93578600370a0a382ecf0511638cf8c20dfc3fb", "parents": [ "4c6da5b96f056a39afdc2833e64edd5d7bcba11b" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Tue Dec 20 15:10:04 2022 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Dec 20 23:44:44 2022 +0000" }, "message": "pre-upload.py: allow \u0027Auto-Submit:\u0027 in cherry picks\n\nPreupload checks of cherry picked commits fail because the\n\u0027Auto-Submit:\u0027 and or \u0027Owners-Override\u0027 tags is not included in the\nlist of tags allowed after \u0027Change-Id\u0027.\n\nLet\u0027s add missing tags to the list.\n\nBUG\u003dNone\nTEST\u003drepo upload attempts of cherry picked commits do not fail due to\n the unsupported tags any more.\n\nChange-Id: If5f07e3b57eb2db757cc085b62256978201f7c8c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4119266\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "4c6da5b96f056a39afdc2833e64edd5d7bcba11b", "tree": "0ef11bdec763f2a72706dc9c8a2f870a3efb26eb", "parents": [ "a74acba9bc13993894c5530833e6c408e321cf17" ], "author": { "name": "Peter Marheine", "email": "pmarheine@chromium.org", "time": "Mon Nov 28 11:40:04 2022 +1100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Dec 15 23:11:32 2022 +0000" }, "message": "pre-upload: make the cache thread-safe\n\nThis changes the Cache class to be used through a decorator that manages\nlocking of the cache to ensure its behavior is correct even when used\nfrom multiple threads and preventing duplicate work when the same value\nis requested concurrently.\n\nBUG\u003dNone\nTEST\u003dpre-upload_unittest.py\n\nChange-Id: Id12a5a96ae722d78ec22a138d0da454e921bb7ff\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4059806\nCommit-Queue: Peter Marheine \u003cpmarheine@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\n" }, { "commit": "a74acba9bc13993894c5530833e6c408e321cf17", "tree": "5974e7dcdc38cd01657e8d192470479f8717b5dc", "parents": [ "6480d839d06cbc2ec8e627adce8c3afe546c95c4" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Dec 15 04:34:06 2022 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Dec 15 22:47:38 2022 +0000" }, "message": "pre-upload: reuse chromite.utils.timer\n\nIt provides everything we\u0027re doing here.\n\nBUG\u003dNone\nTEST\u003d`repo upload` works\n\nChange-Id: I6c41ca5cedd95860e0377cd65d675cde6af3e6c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4108532\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nCommit-Queue: Peter Marheine \u003cpmarheine@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "6480d839d06cbc2ec8e627adce8c3afe546c95c4", "tree": "072b661bee9db0f4dbf023a6d02c9f95ff8f25a1", "parents": [ "9875171b4381f603f12f39fb2fe41dc9e1697fa7" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Dec 15 10:15:13 2022 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Dec 15 20:45:37 2022 +0000" }, "message": "pre-upload: require acct-* eclasses do not set LICENSE\u003d\n\nThis matches what Gentoo is doing.\n\nBUG\u003db:187790077\nTEST\u003dCQ passes\n\nChange-Id: I4080080f3203c8410faabe23e2bb04deebe2cbfe\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4111880\nReviewed-by: Lizzy Presland \u003czland@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "9875171b4381f603f12f39fb2fe41dc9e1697fa7", "tree": "87db0864ca90d39f2202211e816f24435ebda3fb", "parents": [ "7e3b881298c3ea0c6fa36b2ef6fd6def30ffaf12" ], "author": { "name": "Cranel W", "email": "cranelw@chromium.org", "time": "Thu Dec 15 09:44:15 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Dec 15 11:06:48 2022 +0000" }, "message": "pre-upload: accepts BUG\u003doss-fuzz:xxx\n\nBUG\u003dNone\nTEST\u003dpython pre-upload_unittest.py\n\nChange-Id: If72a6a3899ef21cab8ddcf08bd2e730aba120095\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4109447\nReviewed-by: Chih-Yang Hsia \u003cpaulhsia@chromium.org\u003e\nReviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nCommit-Queue: Chih-Yang Hsia \u003cpaulhsia@chromium.org\u003e\nTested-by: Chih-Yang Hsia \u003cpaulhsia@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7e3b881298c3ea0c6fa36b2ef6fd6def30ffaf12", "tree": "c7bf981723bd732e1ddec0766f8b598f85ff7602", "parents": [ "acf1f47fa6fdb5c172b74fbf36114bd9c8d6dd3b" ], "author": { "name": "David Munro", "email": "davidmunro@google.com", "time": "Fri Dec 09 16:25:43 2022 +1100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Dec 13 14:53:54 2022 +0000" }, "message": "pre-upload: Skip clippy if no rust files have been changed\n\nThe cargo clippy check is very slow (10+ minutes if I don\u0027t have a\nrecent cache), and since it applies to system_api changes it often\ntriggers for non-rust changes. So check if there are any rust files\nchanged first and if not skip the rest of the check entirely.\n\nBUG\u003db:238386007\nTEST\u003dUnit tests\nTEST\u003drepo upload with a system_api change, faster now\n\nChange-Id: I721907101486bc34ac87000792c259c4a65fc790\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4090774\nReviewed-by: Lizzy Presland \u003czland@google.com\u003e\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: David Munro \u003cdavidmunro@google.com\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: David Munro \u003cdavidmunro@google.com\u003e\n" }, { "commit": "acf1f47fa6fdb5c172b74fbf36114bd9c8d6dd3b", "tree": "57812ec4d51100cdc03f04ec702aa113997c93a2", "parents": [ "852535eeeda79368fafb500a5adfe19ba37ba8c4" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Dec 02 13:17:05 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 05 05:38:03 2022 +0000" }, "message": "pre-upload: change status from single running to all pending\n\nTo prepare for running in parallel, change the display from showing\nthe single hook that is currently running to all the hooks that are\npending.\n\nBUG\u003dNone\nTEST\u003d`repo upload` works\n\nChange-Id: I2f3afa170345d407d52d914a4d347693c1e8306a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4075046\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "852535eeeda79368fafb500a5adfe19ba37ba8c4", "tree": "5940555d900e1b97bfc8416a6702e0426076c0a2", "parents": [ "b291a2c48b4b61b042c2540ef6eb8730af6bc1f9" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Dec 02 13:45:31 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 05 01:41:23 2022 +0000" }, "message": "pre-upload: further improve flashing presubmit lines\n\nOnly clear the line when we know we\u0027re going to print something new.\nOtherwise the main status line update will take care of it for us.\n\nIt is more lines of code, but the UX is easier on dev\u0027s eyes.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: Id723401878ff90d6cfc9099f2ed6d14ea608981f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4075045\nReviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "b291a2c48b4b61b042c2540ef6eb8730af6bc1f9", "tree": "ae19af6d58c86d8a47e257a2b3d7678f61be13ab", "parents": [ "14588b2266c97cd6aedec651b0f0c8eb907c3e4c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Nov 29 23:05:27 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Nov 30 01:33:43 2022 +0000" }, "message": "pre-upload: avoid flashing presubmit status lines\n\nThe current output will fully erase the status line before redrawing.\nWhen running a bunch of checks after each other, this can cause it to\nflash blankly. Instead, we should move the cursor to the start, draw\nthe new status line over the old one, and then erase anything after\nthe new one (if the new line is shorter than the old). Since status\nlines share a lot of the same form, it\u0027s less janky for users as the\ncommon characters never get reset to spaces.\n\nOld:\n[RUNNING 33/37 PRESUBMIT.cfg] blah blah\n\\r\u003cerase\u003e\n[RUNNING 34/37 PRESUBMIT.cfg] blah blah\n\nNew:\n[RUNNING 33/37 PRESUBMIT.cfg] blah blah\n\\r[RUNNING 34/37 PRESUBMIT.cfg] blah blah\u003cerase\u003e\n\nBUG\u003dNone\nTEST\u003d`repo upload` still works, and is less flashy\n\nChange-Id: Icc35088e234dc16603cabe496045eb758d5d91d1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4062228\nReviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "14588b2266c97cd6aedec651b0f0c8eb907c3e4c", "tree": "cd103f58658536fca00c7b78fe0fa44751f1f0b8", "parents": [ "82b9c1404eae9d2b0943f845279772802c4b76ea" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Nov 29 23:11:30 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Nov 30 00:20:34 2022 +0000" }, "message": "pre-upload: cache isatty check\n\nMinor, but since we never change stdout, we know the check is valid\nfor the life of the process, so only stat stdout once.\n\nBUG\u003dNone\nTEST\u003d`repo upload` still works\n\nChange-Id: Iccf4a9711e1476cbd8ef6eeba1f459907f1b895b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/4062227\nReviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "82b9c1404eae9d2b0943f845279772802c4b76ea", "tree": "6a73123fd87dd849a6f064674423a64062c5bcb6", "parents": [ "ac656c4543cf81c081996466697b3510f7c61df4" ], "author": { "name": "Grace Cham", "email": "hscham@chromium.org", "time": "Tue Oct 25 14:30:00 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Nov 09 07:41:45 2022 +0000" }, "message": "pre-upload: add ignore_merged_commits option\n\nTo provide the option of by-passing presubmit checks on merged commits\nwhen uploading a merge.\nExtract parsing of config file from _get_project_hooks() as a\nstand-alone _get_project_config() function, which will be used by both\n(refactored) _get_project_hooks() and _get_project_options().\n\nThis is primarily to allow repo upload libchrome uprev commits without\npassing the --no-verify flag due to incorrect commit message from\nthe merged cros/upstream commits.\n\nBUG\u003db:255263785\nTEST\u003drepo upload a merge commit from libchrome with new PRESUBMIT.cfg \\\n in crrev.com/c/3976710\n\nChange-Id: Ie506cecf506b03cdcd89f62db156c65e21fee4dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3977728\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nTested-by: Qijiang Yūki Ishii \u003cfqj@google.com\u003e\nReviewed-by: Qijiang Yūki Ishii \u003cfqj@google.com\u003e\nCommit-Queue: Grace Cham \u003chscham@chromium.org\u003e\nAuto-Submit: Grace Cham \u003chscham@chromium.org\u003e\n" }, { "commit": "ac656c4543cf81c081996466697b3510f7c61df4", "tree": "7d3382d002e2659b77ea63f1129785f08b9fd696", "parents": [ "f0b1f4082515058ecfd67f7abd6e87e6c5a40552" ], "author": { "name": "Keith Short", "email": "keithshort@chromium.org", "time": "Wed Nov 02 15:10:36 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Nov 02 21:58:01 2022 +0000" }, "message": "pre-upload: don\u0027t echo black check command line\n\nDon\u0027t echo the command line used to run the black check on python files.\nThis follows the convention of all other checks to only print out\nwarnings and errors.\n\nBUG\u003dnone\nTEST\u003dRun the pre-upload unit test\n\nChange-Id: I5617aa891b58dbd4206e3e30e7f2246dc6b1684c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3999486\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nTested-by: Keith Short \u003ckeithshort@chromium.org\u003e\nCommit-Queue: Keith Short \u003ckeithshort@chromium.org\u003e\n" }, { "commit": "f0b1f4082515058ecfd67f7abd6e87e6c5a40552", "tree": "0cd5b7a916742095ceaa45d0812b8c9ca1ea91c2", "parents": [ "0577ffe2ef877633d964b0cccf9cd3e89df50507" ], "author": { "name": "Sloan Johnson", "email": "sloanjohnson@google.com", "time": "Fri Oct 14 19:02:12 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Oct 14 19:18:54 2022 +0000" }, "message": "pre-upload_unittest.py: Check that CLA check is enabled by default\n\nBUG\u003db:251580883\nTEST\u003d./pre-upload_unittest.py\n\nChange-Id: I9ea018a43d490b1cf2dfefe12be4c9c12da1d4f1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3956301\nCommit-Queue: Sloan Johnson \u003csloanjohnson@google.com\u003e\nAuto-Submit: Sloan Johnson \u003csloanjohnson@google.com\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nTested-by: Sloan Johnson \u003csloanjohnson@google.com\u003e\nCommit-Queue: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\n" }, { "commit": "0577ffe2ef877633d964b0cccf9cd3e89df50507", "tree": "d2d20b14b6190b4cc1a0e964e0d371d2a936a779", "parents": [ "3f7cb4a8c6dd99247e4450feb73b9f284d2b21cc" ], "author": { "name": "Sloan Johnson", "email": "sloanjohnson@google.com", "time": "Tue Oct 11 23:05:21 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 13 21:39:13 2022 +0000" }, "message": "pre-upload.py: Add --no-cla-check option to allow running while rebasing\n\nThe pre-upload CLA check requires being on a branch. To allow using the\ncommand for checking while rebasing, add a --no-cla-check option to skip\nthat check.\n\nBUG\u003db:251580883\nTEST\u003d`pre-upload.py --no-cla-check HEAD` during rebase, pass CQ\n\nChange-Id: I44d5e985fab99d18b6f37e686fa22e4d33ef3dc4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3952982\nAuto-Submit: Sloan Johnson \u003csloanjohnson@google.com\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nTested-by: Sloan Johnson \u003csloanjohnson@google.com\u003e\n" }, { "commit": "3f7cb4a8c6dd99247e4450feb73b9f284d2b21cc", "tree": "f41396072b61fa713a781bc30bb6bb94dbe240af", "parents": [ "1eed5a14a5d62ce3caa0def7a34375a45f468184" ], "author": { "name": "Ricardo Ribalda", "email": "ribalda@chromium.org", "time": "Wed Sep 28 13:45:08 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 28 20:19:42 2022 +0000" }, "message": "pre-upload: Check for multi-line Cq-Depends\n\nIf Cq-depends spans across multiple lines, only the first line is\nconsidered by the CQ. Tell the user about it\n\nBUG\u003db:248248661\nTEST\u003drun pre-upload.py on a malformed CL\n\nChange-Id: Ieb34afabc2326db32b4acd401e77a1bd6b1c6958\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3924480\nAuto-Submit: Ricardo Ribalda \u003cribalda@chromium.org\u003e\nCommit-Queue: Ricardo Ribalda \u003cribalda@chromium.org\u003e\nTested-by: Ricardo Ribalda \u003cribalda@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "1eed5a14a5d62ce3caa0def7a34375a45f468184", "tree": "357afffd1ed65bcfccc5494207523ca1a775f8f3", "parents": [ "a0cf02dfc909cbd49021ea868d72b88fcdf9dc78" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 29 00:33:41 2022 +0545" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 28 20:08:17 2022 +0000" }, "message": "PRESUBMIT: add cros format checking\n\nBUG\u003dNone\nTEST\u003d`repo upload` passes\n\nChange-Id: I7af5c01dfc0a3cb87f0254ea1d8802d85a576fc3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3924488\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\nCommit-Queue: Cindy Lin \u003cxcl@google.com\u003e\n" }, { "commit": "a0cf02dfc909cbd49021ea868d72b88fcdf9dc78", "tree": "a94d54fc083888b216997d6a87c6c551b01450f9", "parents": [ "04df6053c0b2909529a203fb21d8abfab16d726a" ], "author": { "name": "Cindy Lin", "email": "xcl@google.com", "time": "Tue Sep 27 17:58:49 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 27 20:32:55 2022 +0000" }, "message": "pre-upload: Exclude layout.conf from long lines\n\nAdd layout.conf files to LONG_LINE_OK_PATHS so that lines longer than 80\ncharacters won\u0027t get flagged in these files.\n\nBUG\u003db:244784873\nTEST\u003d`./pre-upload_unittest.py`\n\nChange-Id: I926ed3f61117c0632a4844b4a7c9b2fc434b5e40\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3922303\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Cindy Lin \u003cxcl@google.com\u003e\nCommit-Queue: Cindy Lin \u003cxcl@google.com\u003e\n" }, { "commit": "04df6053c0b2909529a203fb21d8abfab16d726a", "tree": "4797ec64b2a48f0fb2e771529658f1798dea71d9", "parents": [ "b298649ec8d0c59132146a53f93927e78b30b9b2" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Fri Sep 23 08:15:43 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 23 16:15:47 2022 +0000" }, "message": "clang-format: Expect non-zero exit code when formatting changes are required\n\nPrior to https://github.com/llvm/llvm-project/commit/f9a2f6b6ae,\ngit-clang-format had a bug where it would return zero when formatting\nchanges were required in --diff mode. Our wrapper script relied on\nthat bug.\n\nFix it so that it does no longer.\n\nBUG\u003db:247800275\nTEST\u003dmess up a file\u0027s formatting\n ./pre-upload.py gives a nice list of files that need reformatted\n\nChange-Id: I543d42beaa2211143de01a0954582f028c2d6ac9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3916351\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "b298649ec8d0c59132146a53f93927e78b30b9b2", "tree": "5b52cdc4cd0e600e906548fa1217b4aeffe7dd35", "parents": [ "702f09fa98a5a092e61d487ea2e70a77add29d35" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Sep 13 12:36:47 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 19:40:32 2022 +0000" }, "message": "pre-upload: include GN files in license checks\n\nBUG\u003dchromium:1098010\nTEST\u003d`repo upload` works\n\nChange-Id: I328b1737ba885849105d5d5f0c8ebe5294053f0c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3894032\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "702f09fa98a5a092e61d487ea2e70a77add29d35", "tree": "03a02dfcb4d69e3a66957fa83cc47f7b0a629264", "parents": [ "a550833c460cae1908c81e3418687999f3ff02a3" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 15 05:52:51 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 16:40:06 2022 +0000" }, "message": "layout.conf: require cache-format now\n\nSince we\u0027ve updated all our overlays to turn this on, enforce it with\nnew ones to make sure it stays on everywhere.\n\nBUG\u003db:242194202\nTEST\u003dCQ passes\n\nChange-Id: Ic09907cfb675a822df8d6ef2254196257c348120\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3898324\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "a550833c460cae1908c81e3418687999f3ff02a3", "tree": "f400f5913533a42840f00becea85518846ed77f4", "parents": [ "f9ee56174db415693d87f9af6ee732cbeaf46a2c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 12 04:39:37 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 13 11:20:18 2022 +0000" }, "message": "reformat with black\n\nBUG\u003db:233893248\nTEST\u003d`repo upload` works\n\nChange-Id: I971857f34dc583d1e6862e44cca2010b58e4878a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3889674\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "f9ee56174db415693d87f9af6ee732cbeaf46a2c", "tree": "0375080388680ac97c705ade54a974f6a2a6b911", "parents": [ "b6d75e6356355fddf7b64bc724b9c77bcb14537d" ], "author": { "name": "Chung-Sheng Wu", "email": "chungsheng@google.com", "time": "Mon Sep 12 19:20:46 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 12 12:28:26 2022 +0000" }, "message": "Fix wrong error message in _check_cros_license\n\nBUG\u003dchromium:1098010\nTEST\u003dRun repo upload with other CL.\n\nChange-Id: I4e5daf713ff44cc8276dc0c983751ce06d7f128e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3890027\nAuto-Submit: Chung-Sheng Wu \u003cchungsheng@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Chung-Sheng Wu \u003cchungsheng@google.com\u003e\n" }, { "commit": "b6d75e6356355fddf7b64bc724b9c77bcb14537d", "tree": "97dd00dfe83fc09c3a210511c075bdc59da4f18f", "parents": [ "3f570ce4b5ce300dce21d0061ac596802e2c03ce" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Sep 07 08:54:39 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 09 16:08:41 2022 +0000" }, "message": "pre-upload: lock down copyright checks\n\nWe\u0027re doing a tree-wide update to handle all the copyright changes.\nSo there\u0027s no need to allow old styles anymore.\n\nBUG\u003dchromium:1098010\nTEST\u003d./pre-upload_unittest.py passes\n\nChange-Id: Id8db836a31375085d15b579729a06da9147961d8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3876909\nCommit-Queue: Cindy Lin \u003cxcl@google.com\u003e\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3f570ce4b5ce300dce21d0061ac596802e2c03ce", "tree": "a32a31b1502dcb5f11b8fd40e3c6f57f17c21c8c", "parents": [ "7411d41d2d1d6962d1442678c783b4120eeac651" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Sep 07 08:46:15 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 07 18:01:50 2022 +0000" }, "message": "Update license boilerplate text in source code files\n\nNormally we don\u0027t do this, but enough changes have accumulated that\nwe\u0027re doing a tree-wide one-off update of the name \u0026 style.\n\nBUG\u003dchromium:1098010\nTEST\u003d`repo upload` works\n\nChange-Id: I087c21a97762bc8ec9c0ad70a914818576ec19ab\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3876908\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7411d41d2d1d6962d1442678c783b4120eeac651", "tree": "fefa8690ad70f75f7ee35b4c00f660c1c33bd292", "parents": [ "1e64b7aa4ef78a15508588b539420319b773e0db" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Tue Aug 30 16:17:11 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 31 20:37:41 2022 +0000" }, "message": "pre-upload: compile regexes once per hook\n\n_filter_files runs `re.search()` for each file, for each regex.\n`re.search` may compile the regex, or may use a prior cached compilation\nof said regex. Rather than forcing cache lookups and potentially misses,\ncompile all regexes in one shot.\n\nBUG\u003db:242587835\nTEST\u003dUnittests\n\nChange-Id: I74a1a680ce6f4b4cc7256e89d460c22f26e3e535\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3866504\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\n" }, { "commit": "1e64b7aa4ef78a15508588b539420319b773e0db", "tree": "25f6c7e07ba31e0be99ac1a57c1ad1ccbc59248c", "parents": [ "b2c55387b9adba1e18abe28c936980c5b9c290f7" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Tue Aug 30 16:04:04 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 31 20:37:40 2022 +0000" }, "message": "pre-upload: make rustfmt optional\n\n`third_party/rust_crates` should only have Rust code in its `vendor/`\ndirectory. Checking the formatting of that code isn\u0027t useful.\n\nBUG\u003db:242587835\nTEST\u003drepo upload in rust_crates\n\nChange-Id: I98da1c5d48cf26657aa8b88385cc2688ec6339a8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3866503\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "b2c55387b9adba1e18abe28c936980c5b9c290f7", "tree": "94236d292fd2d11852a389d206cd3c2861c1263e", "parents": [ "32b1168199c41dc9e6e0b91dfe37b0568dee538d" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Tue Aug 30 16:22:41 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 31 20:37:39 2022 +0000" }, "message": "pre-upload_unittest: fix\n\n- migrate to CompletedProcess, which replaced CommandResult.\n- use a Path in ProjectNamed, since we use `Path(x)` on it in rustfmt\n checks\n\nBUG\u003db:187789262, b:242587835\nTEST\u003d./pre-upload_unittest.py\n\nChange-Id: I92a46e540974317d68da8522651c5cb97c606b7d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3866502\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\n" }, { "commit": "32b1168199c41dc9e6e0b91dfe37b0568dee538d", "tree": "97abb8fb812a4a9882bf7a2d81b6ec174a7bca22", "parents": [ "712f254bb49e9b3964f3ed850f790f66178e9ec6" ], "author": { "name": "Li-Yu Yu", "email": "aaronyu@google.com", "time": "Mon Aug 08 20:51:00 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 10 04:40:26 2022 +0000" }, "message": "pre-upload: measure execution time of hooks\n\nBUG\u003db:241742708\nTEST\u003d./pre-upload.py | cat\n\nChange-Id: I747cf825cb99c7a668794d8c8d5377122662078c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3814948\nTested-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nCommit-Queue: Li-Yu Yu \u003caaronyu@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "712f254bb49e9b3964f3ed850f790f66178e9ec6", "tree": "bc4c57c949c87d22e958d4ae6d3b6a576cd3f6cc", "parents": [ "f227a9d4ab336ac3c7582c3427885e4b2f3d3a1a" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Aug 09 19:39:33 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 10 03:04:02 2022 +0000" }, "message": "pre-upload: only use terminal escape sequences with ttys\n\nIf the output is going to a log file or a pager, don\u0027t try to clear\nthe screen or other terminal shenanigans.\n\nBUG\u003dNone\nTEST\u003d`repo upload | less` doesn\u0027t clear lines\n\nChange-Id: Iceff22f9a04f6253119198a99be73a2d5636b788\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3820405\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "f227a9d4ab336ac3c7582c3427885e4b2f3d3a1a", "tree": "a93481cd9dcadf362b27c2159c484361cc6f54c5", "parents": [ "2eee4226741c9934f0dfd9fea472a5d7fe28f572" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Aug 08 02:06:20 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Aug 09 07:06:12 2022 +0000" }, "message": "pre-upload: optimize output a little\n\nUse CSI terminal escapse sequences to erase the entire line for us.\nThis tends to be faster for terminals to process.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I6f3212203156e9a27093a3b5f479801186d1aea6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3813711\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Li-Yu Yu \u003caaronyu@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Li-Yu Yu \u003caaronyu@google.com\u003e\nTested-by: Li-Yu Yu \u003caaronyu@google.com\u003e\n" }, { "commit": "2eee4226741c9934f0dfd9fea472a5d7fe28f572", "tree": "613a428c5cf1f95b397bd53e6fb3cde6e1929f38", "parents": [ "f1b0e60be5d879be747eeebeb0f0f9a29820cc47" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Aug 05 14:17:33 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Aug 09 06:11:38 2022 +0000" }, "message": "pre-upload: exclude ebuilds \u0026 eclasses from license checks\n\nThis basically reverts commit 4d6c796e9074a7b17acd6781d06e941dc78b2fca.\n\nThis is forcing devs to change ebuild licenses from GPL-2 to BSD, even\nones that we didn\u0027t author. We only wanted to enforce the Copyright\nstyle when using CrOS authors. Let\u0027s exclude them again until we can\nfind a way to do this safely.\n\nBUG\u003db:230609017\nTEST\u003d`./pre-upload_unittest.py`\n\nChange-Id: I2d315d0e72bd648f3b7b86bdba89ede7a5c8e834\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3810670\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "f1b0e60be5d879be747eeebeb0f0f9a29820cc47", "tree": "aa1a692338f1e31e3025a097629c7b5aff4c85cc", "parents": [ "c3f82c73dbbcf7a890752a95147759b9a0d681bf" ], "author": { "name": "Keigo Oka", "email": "oka@google.com", "time": "Thu Aug 04 08:10:46 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 05 00:51:01 2022 +0000" }, "message": "pre-upload: Add TypeScript to common included paths\n\nWe will get the following checks for TypeScript\n\n* Checks there are no multiple blank lines at end of file.\n* Checks that there is no stray whitespace at source lines end.\n* Checks there are no unexpanded tabs.\n* Checks there are no blocked keywords in commit content.\n* Verifies the Chromium OS license/copyright header\n\nBUG\u003db:240887161\nTEST\u003drepo upload in cros-ide\n\nChange-Id: Ia534c3955c9c20efd878225018fa502d4e181fc3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3810251\nReviewed-by: Tomasz Tylenda \u003cttylenda@chromium.org\u003e\nTested-by: Keigo Oka \u003coka@chromium.org\u003e\nCommit-Queue: Keigo Oka \u003coka@chromium.org\u003e\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\n" }, { "commit": "66253597c629ee0a47790a5f68288a30fd62bb5c", "tree": "c4742651cffe2e8113759bfc00acd3c89e623ba2", "parents": [ "e176a9976b81b6a2f7c5665556349ac2f71595d3" ], "author": { "name": "Chenglong Tang", "email": "chenglongtang@google.com", "time": "Tue Aug 02 20:57:08 2022 +0000" }, "committer": { "name": "Chenglong Tang", "email": "chenglongtang@google.com", "time": "Wed Aug 03 20:21:50 2022 +0000" }, "message": "Add copy-and-pasteable license text into license check errors\n\nBUG\u003db/175892198\nTEST\u003dhttp://sponge2/1829fd1a-8d7f-4d1b-9fc1-54f310b66eba\nRELEASE_NOTE\u003dNone\n\nChange-Id: I2cd37cca1cea732273cdaf4e46f2f8764a11f70c\nReviewed-on: https://cos-review.googlesource.com/c/cos/repohooks/+/35548\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "c3f82c73dbbcf7a890752a95147759b9a0d681bf", "tree": "5942d6649dbf4a3918c4008ccdc81c129ef88882", "parents": [ "4d6c796e9074a7b17acd6781d06e941dc78b2fca" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Aug 02 06:19:50 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Aug 02 15:02:38 2022 +0000" }, "message": "pre-upload: clean up failed summary\n\nShow the actual path to the README for people to copy \u0026 paste, and\nshow the `repo upload .` tip only if multiple projects are used.\n\nBUG\u003dNone\nTEST\u003d`repo upload .` is cleaner on failure\n\nChange-Id: I1c11b63464fb569bb4a7fac07b9e8084dd46b7f6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3804206\nReviewed-by: Cindy Lin \u003cxcl@google.com\u003e\nCommit-Queue: Cindy Lin \u003cxcl@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "4d6c796e9074a7b17acd6781d06e941dc78b2fca", "tree": "94c86aa18c8e7e78b78faed2fc406c1805e3da60", "parents": [ "dcb7597b7d8473aef208b87b165c7f14898eafda" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Jul 29 10:37:25 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Aug 01 18:26:33 2022 +0000" }, "message": "pre-upload: include ebuilds \u0026 eclasses in license checks\n\nBUG\u003db:230609017\nTEST\u003d`./pre-upload_unittest.py`\n\nChange-Id: Ic6b5dcdb1a625001db55330eadc328320aeb756f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3791630\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "dcb7597b7d8473aef208b87b165c7f14898eafda", "tree": "868d46af625c4a4856241a97d8ac703450a4b67f", "parents": [ "c360f04959a83b3d5bd568a1bcd0e911448bcb73" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Jul 20 17:05:09 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 20 22:16:18 2022 +0000" }, "message": "pre-upload: run all commands non-interactively by default\n\nWe really don\u0027t want repohooks interacting with the user, so force\ninput to /dev/null by default.\n\nBUG\u003db:238386007\nTEST\u003d`repo upload` works\n\nChange-Id: I2cd43176b4907d71c55b792b4c98cff2c0575005\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3777284\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "c360f04959a83b3d5bd568a1bcd0e911448bcb73", "tree": "a16688fafc0834db24423e3c087dfcdd0109adf2", "parents": [ "d05323f267c480dc094d4c8370ca1947558b43b0" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 19 11:11:11 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jul 19 16:44:12 2022 +0000" }, "message": "pre-upload: run cargo in non-interactive mode\n\nThese cargo commands shouldn\u0027t be prompting the user, so disable\nstdin to signal to cros_sdk that we we\u0027re non-interactive.\n\nBUG\u003db:238386007\nTEST\u003d`repo upload` works\n\nChange-Id: I70cb31d3775fcd9fcb9a2c8cb0d2cc3aa105be04\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3773753\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "d05323f267c480dc094d4c8370ca1947558b43b0", "tree": "8a9b0fe5ecb8c70025cfc333dfcbe58670241761", "parents": [ "1ed251b72303a6962ccc1d4b3faac80331a95115" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 19 11:13:18 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jul 19 16:21:54 2022 +0000" }, "message": "pre-upload: update run API\n\noutput \u0026 error were renamed to stdout \u0026 stderr a while ago.\nUpdate this code too.\n\nBUG\u003db:187789262\nTEST\u003d`./pre-upload_unittest.py` doesn\u0027t warn anymore\n\nChange-Id: Icbad3cc3c1ab77dffeb4967cde3b44d4d3551a2b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3773754\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "1ed251b72303a6962ccc1d4b3faac80331a95115", "tree": "659c96a8919713b55a7cc86465d2c808ccf0c5c4", "parents": [ "42602f0414791a2dbe9d7b6623dc368c55372a70" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Mon Jul 18 13:22:52 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jul 18 20:29:30 2022 +0000" }, "message": "pre-upload: black_check: Fix diff output encoding\n\nWithout setting encoding\u003d\u0027utf-8\u0027, the output looks rather funky:\n\n b\u0027--- STDIN\\t2022-07-18 19:17:25.129761 +0000\\n+++ STD...\n\nSet that.\n\nBUG\u003db:238434058\nTEST\u003dIn src/platform/ec, run pre-upload.py on\n commit c3dd6d0fc27f0d844dced10e27210efe76b1e344\n The output is now not the repr of the bytes.\n\nChange-Id: I8dd5b22aac6e3451a206e1021bd690886cd0e52c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3770319\nAuto-Submit: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "42602f0414791a2dbe9d7b6623dc368c55372a70", "tree": "2b2cbd86986be4e502567faf93dbf9b53a214f1f", "parents": [ "ce8db5c1901d5cf090c780319214731a445596c1" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Tue Jul 12 15:01:34 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jul 18 18:42:43 2022 +0000" }, "message": "pre-upload: Add black_check common hook\n\nFor codebases which want all Python code formatted with black, provide\na common hook that can be added in PRESUBMIT.cfg to do so.\n\nA default pyproject.toml is specified which is compliant with Google\u0027s\nexternal python style recommendation of 80 column lines. Projects may\nuse their own simply by creating a pyproject.toml with a \"tool.black\"\nsection.\n\nBUG\u003db:238434058\nTEST\u003dprovided unit tests pass\n\nChange-Id: I30c56768a3a654dee46ba99ccc211e3900db502a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3759266\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "ce8db5c1901d5cf090c780319214731a445596c1", "tree": "b6786f2594b522b9aee08395bacda4a8adb8746d", "parents": [ "b03ba18e5d45a6782555c1e41fca0bb218f3868a" ], "author": { "name": "Alyssa Haroldsen", "email": "kupiakos@google.com", "time": "Tue Jul 12 13:59:04 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jul 18 17:35:53 2022 +0000" }, "message": "repohooks: Disable enter_chroot when outside a Chromium OS tree\n\nRight now, running `repo upload -c .` in Ti50\u0027s outside-chroot\nworkflow results in rustfmt always outputting the following, making\nevery format check fail:\n\n```\n13:43:32.623: ERROR: No SDK version was found. Are you in a Chromium\nsource tree instead of Chromium OS?\n\nPlease change to a directory inside your Chromium OS source tree\nand retry. If you need to setup a Chromium OS source tree, see\n https://dev.chromium.org/chromium-os/developer-guide\n```\n\nThis changes the logic to avoid trying to enter the chroot if it is not\na proper ChromiumOS chroot, by checking for a well-known version file.\n\nBUG\u003dNone\nTEST\u003drepo upload -c . now works as expected inside and outside chroot\n\nChange-Id: I2baa246d55c2d0e69490802340782211557419e4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3759265\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nAuto-Submit: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\nTested-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n" }, { "commit": "b03ba18e5d45a6782555c1e41fca0bb218f3868a", "tree": "e786b0d6140fd34ac291df6eab71d5590886f4e3", "parents": [ "6d1503d46ad94284a274adfa5707f6fe74d689aa" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Tue Jun 28 20:35:04 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 30 23:48:28 2022 +0000" }, "message": "pre-upload: Compute the manifest path and pass it directly.\n\nThe clippy check uses enter_chroot. cros_build_lib forces cwd to\nsrc/scripts when enter_chroot is true, so pass the manifest path to\ncargo as a workaround. This also cleans up the output before sudo is\nrun to enter the chroot and provides an explaination.\n\nBUG\u003db:237423655\nTEST\u003drepo upload from the root of the source tree outside the chroot.\n\nChange-Id: Iafa74b3a383035b7a23ffe09850f8ff7ce45dea8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3733517\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nAuto-Submit: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "6d1503d46ad94284a274adfa5707f6fe74d689aa", "tree": "bc6f3e53c8492b94f4cff67f07ddd32945783e03", "parents": [ "e322b4af8abd1bc63a98c42bb4e831320d02f79a" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Tue Jun 21 16:41:24 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 22 15:43:11 2022 +0000" }, "message": "pre-upload: Enter the chroot to run clippy.\n\nSupport running preupload checks outside the chroot by telling\ncros_build_lib\u0027s run function to enter the chroot to run rustfmt and\ncargo.\n\nThis also fixes https://crrev.com/c/3710170 which was missing a\ncheck\u003dTrue parameter when running a git check.\n\nBUG\u003db:236319101\nTEST\u003dRun preupload checks outside the chroot without cargo\n\nChange-Id: If1bed06ba0171e31d98d20c51ac68d9f69d5a78f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3717102\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nAuto-Submit: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "e322b4af8abd1bc63a98c42bb4e831320d02f79a", "tree": "8ce3b0a84b664be63cf22fd581e6f603d0c8f6c0", "parents": [ "edc7c6798a37f2ba5dc0ba4b5dbe8e3db052be4e" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Thu Jun 16 14:28:46 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 16 15:45:42 2022 +0000" }, "message": "pre-upload: Regenerate Cargo.lock for clippy check.\n\nFor subprojects that do not track Cargo.lock via git, regenerate the\nCargo.lock file so that any updated dependencies do not cause the\npresubmit check to fail.\n\nBUG\u003dNone\nTEST\u003drepo upload # for a platform2 Rust project like cronista.\n\nChange-Id: I241bd72787a54184e09f4bb83592dd20034cb1df\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3710170\nReviewed-by: Evan Green \u003cevgreen@chromium.org\u003e\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "edc7c6798a37f2ba5dc0ba4b5dbe8e3db052be4e", "tree": "db933dd2ef5de00df5b041723195259f71dcbfee", "parents": [ "ac194149725d818ae5708f0b7d901afa4f50e4bc" ], "author": { "name": "Cindy Lin", "email": "xcl@google.com", "time": "Thu May 26 20:59:03 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 27 16:56:14 2022 +0000" }, "message": "README: Update reporting issues link\n\nBUG\u003db:233613922\nTEST\u003dNone\n\nChange-Id: I4dd321e4f3230a7854c0edfa221066dd545a63c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3671598\nAuto-Submit: Cindy Lin \u003cxcl@google.com\u003e\nReviewed-by: Lizzy Presland \u003czland@google.com\u003e\nCommit-Queue: Lizzy Presland \u003czland@google.com\u003e\nTested-by: Cindy Lin \u003cxcl@google.com\u003e\n" }, { "commit": "ac194149725d818ae5708f0b7d901afa4f50e4bc", "tree": "f1784b78b6113aebe12ea6423408c99777eb431e", "parents": [ "b9f4227242ffe2f34574bec93210cde9a1fc1859" ], "author": { "name": "Alex Klein", "email": "saklein@chromium.org", "time": "Thu May 12 12:34:21 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 18 19:23:29 2022 +0000" }, "message": "pre-upload: Update copyright/license header check\n\nUpdate Chromium OS to ChromiumOS. Remove all rights reserved.\n\nBUG\u003db:230609017\nTEST\u003dpytest pre-upload_unittest.py\n\nChange-Id: Id86befbb4c0baa5ef13e10c82bc1e90e727955aa\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3646110\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Sergey Frolov \u003csfrolov@google.com\u003e\nTested-by: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "b9f4227242ffe2f34574bec93210cde9a1fc1859", "tree": "20cb97a91e51ecfb383e29849f91ea73a2bed270", "parents": [ "f9b0dbef09bec2bf13375d4ba3d09e576f201987" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Mon May 16 16:58:14 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 17 17:27:03 2022 +0000" }, "message": "Remove gendered pronouns from blocked_terms.txt\n\nThe inclusive language guidelines have been adjusted to allow for the use of\ngendered pronouns when referring to a specific individual with such pronouns.\nAs such, we do not need to block these globally from use within the codebase.\n\nBUG\u003dNone\nTEST\u003d./blocked_terms_unittest.py\n\nChange-Id: Ib2df9a8aa1e4497b0dc5280fbe14fd68f38c1c85\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3650053\nReviewed-by: Greg Edelston \u003cgredelston@google.com\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "f9b0dbef09bec2bf13375d4ba3d09e576f201987", "tree": "0505edf1a32077336df1656656449dc6fe053252", "parents": [ "86195aa83974010b51fb63989c0099e848a6ac61" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Thu May 12 23:12:04 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat May 14 04:10:32 2022 +0000" }, "message": "rust: update repo name\n\nAccording to .repo/manifests, the repo name for this is a bit different\nthan what\u0027s here.\n\nBUG\u003db:232421884\nTEST\u003d`repo upload` with a virtual/rust version bump\n\nChange-Id: I68b98c07c8a9a0f8b9d61c609626ae91f9da173b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3647002\nAuto-Submit: George Burgess \u003cgbiv@chromium.org\u003e\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "86195aa83974010b51fb63989c0099e848a6ac61", "tree": "ce327aa80394385b1aa6fe8d037b7fa429da147f", "parents": [ "b63d5db01a9fc606414fa5393c53ccba327dd164" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed May 11 16:02:28 2022 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 12 20:36:38 2022 +0000" }, "message": "clang-format: switch to dbg_run\n\nThis doesn\u0027t change the default behavior -- commands aren\u0027t shown.\nBut if the user manually specifies --debug, we include it.\n\nBUG\u003dNone\nTEST\u003d`clang-format.py --debug --working-tree dev-install/*.cc` shows the commands\n\nChange-Id: Id4eeb142a32f3289b7ae7dccba19ce70d98133b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3640514\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Alex Klein \u003csaklein@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\n" } ], "next": "b63d5db01a9fc606414fa5393c53ccba327dd164" }