tree aada0500a4a06462b9addecbd515f908c7b58562
parent bfd695c2012db6271b4d89fc56548ac81caddc56
author edisonhello <edisonhello@google.com> 1630656710 +0800
committer Commit Bot <commit-bot@chromium.org> 1630905402 +0000

pre-upload: Use _get_file_content in blank_line_check

The original design of blank_line_check uses the current content
of the file. This causes

1. Error when there is a CL removing the file which was changed in the
previous CL.
2. False negative when the latter CL deleted the blank line, while the
previous CL still had blank line.

Use _get_file_content to retrieve the content of the file in each
commit, so that the two issues above are resolved.

BUG=none
TEST=`repo upload` on CL:3139536 fails
TEST=./pre-upload_unittest.py

Change-Id: I267b3f8f267c6f53049065b9111aa5e75965b067
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/3138163
Commit-Queue: Kuan-Yu Chen <edisonhello@google.com>
Tested-by: Kuan-Yu Chen <edisonhello@google.com>
Auto-Submit: Kuan-Yu Chen <edisonhello@google.com>
Reviewed-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>