commit 52b537ec9681cd9ff55ce117376158126f95d9bf
author Mike Frysinger <vapier@chromium.org> Thu Aug 22 22:59:53 2013 -0400
committer Mike Frysinger <vapier@chromium.org> Fri Sep 06 13:10:38 2013 +0000
tree eae52f4df1b13a1e98bd3d08a6591e2c3665707f
parent df98070ca72bd30aa6d7ba2fb6376f62d7bb3d02

scan Manifest files in ebuild overlays

We only want DIST lines in Manifest files, so add a check to scan
for it.  Devs that do custom imports often forget.

BUG=None
TEST=manual with custom Manifest files (good and bad)

Change-Id: I277e434e871c36f3b914f2076179fbf542aa46d0
Reviewed-on: https://chromium-review.googlesource.com/66762
Reviewed-by: Matt Tennant <mtennant@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index 9501d00..f7cbeb9 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -516,6 +516,27 @@
       return HookFailure('Invalid JSON in %s: %s' % (f, e))
 
 
+def _check_manifests(project, commit):
+  """Make sure Manifest files only have DIST lines"""
+  paths = []
+
+  for path in _get_affected_files(commit):
+    if os.path.basename(path) != 'Manifest':
+      continue
+    if not os.path.exists(path):
+      continue
+
+    with open(path, 'r') as f:
+      for line in f.readlines():
+        if not line.startswith('DIST '):
+          paths.append(path)
+          break
+
+  if paths:
+    return HookFailure('Please remove lines that do not start with DIST:\n%s' %
+                       ('\n'.join(paths),))
+
+
 def _check_change_has_branch_field(project, commit):
   """Check for a non-empty 'BRANCH=' field in the commit message."""
   BRANCH_RE = r'\nBRANCH=\S+'
@@ -579,6 +600,8 @@
 # dict[project] = [callback1, callback2]
 _PROJECT_SPECIFIC_HOOKS = {
     "chromeos/autotest-tools": [_run_json_check],
+    "chromeos/overlays/chromeos-overlay": [_check_manifests],
+    "chromeos/overlays/chromeos-partner-overlay": [_check_manifests],
     "chromeos/platform/ec-private": [_run_checkpatch_no_tree,
                                      _check_change_has_branch_field],
     "chromeos/third_party/coreboot": [_check_change_has_branch_field,
@@ -587,6 +610,9 @@
     "chromeos/vendor/kernel-exynos-staging": [_run_checkpatch,
                                               _kernel_configcheck],
     "chromeos/vendor/u-boot-exynos": [_run_checkpatch_no_tree],
+    "chromiumos/overlays/board-overlays": [_check_manifests],
+    "chromiumos/overlays/chromiumos-overlay": [_check_manifests],
+    "chromiumos/overlays/portage-stable": [_check_manifests],
     "chromiumos/platform/ec": [_run_checkpatch_no_tree,
                                _check_change_has_branch_field],
     "chromiumos/platform/mosys": [_check_change_has_branch_field],